[release/9.4] Harden Docker container runtime health check #10408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
davidfowl
approved these changes
Jul 15, 2025
danegsta
approved these changes
Jul 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10402 to release/9.4
/cc @captainsafia
Customer Impact
In 9.4, the container-runtime “health check” could report healthy even when the Docker daemon was stopped or mis-configured because it was updated to use the
docker buildx versioncheck which always returns with a zero status code even if Docker is not running.We update the code to use the same check DCP uses for an active Docker instance and update the Podman runtime to use the same check.
Testing
Risk
Low. The code touches only the health-check helpers; no other build or run-time paths are affected. Change also keeps us consistent with existing pattern in DCP.
Regression?
No.