[3.x] Migrate GenerateFileFromTemplate to Microsoft.DotNet.Build.Tasks.Templating #7503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lating (#7403) Co-authored-by: Viktor Hofer <[email protected]> Co-authored-by: Doug Bunting <[email protected]> Co-authored-by: Rainer Sigwald <[email protected]>
added 2 commits
June 10, 2021 12:22
markwilkie
approved these changes
Jun 10, 2021
Member
markwilkie
left a comment
markwilkie
left a comment
There was a problem hiding this comment.
This backport should be fine. Maybe wait for a little bit to "bake" in main?
dougbu
reviewed
Jun 10, 2021
src/Microsoft.DotNet.Build.Tasks.Templating/test/GenerateFileFromTemplateTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Build.Tasks.Templating/test/GenerateFileFromTemplateTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Build.Tasks.Templating/test/GenerateFileFromTemplateTests.cs
Outdated
Show resolved
Hide resolved
Author
|
We have started using the package and task in aspnetcore on the main branch: dotnet/aspnetcore#33449. Is that enough "baking"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7403