Make SignTool not fail when a cross generated file doesn't have PKT #2170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
reviewed
Mar 5, 2019
tmat
approved these changes
Mar 5, 2019
tmat
reviewed
Mar 5, 2019
JunTaoLuo
pushed a commit
to aspnet/BuildTools
that referenced
this pull request
Mar 18, 2019
To get dotnet/arcade#2170 fix
JunTaoLuo
pushed a commit
to aspnet/BuildTools
that referenced
this pull request
Mar 18, 2019
This was referenced Jan 5, 2023
DotDeveloper95
added a commit
to DotDeveloper95/BuildTools
that referenced
this pull request
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2159
SignTool currently fails with "Could not load file or assembly 'xyz.dll' or one of its dependencies. An attempt was made to load a program with an incorrect format." when a cross generated file doesn't have PKT. See sample build here.
This PR make SN not fail in such scenario and also add a new test case to check that.