[java-runtime] move MonoPackageManager.Context to ApplicationRegistration
#9779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tration` Calling `Android.App.Application.Context` currently reads the `mono.MonoPackageManager.Context` field, which is set on startup by a `ContentProvider`. `mono.MonoPackageManager` does not exist in NativeAOT (or CoreCLR), so let's move the field to: * `net.dot.android.ApplicationRegistration.Context` The `ApplicationRegistration` class is already used in NativeAOT, so this can work for all of the runtimes.
jonathanpeppers
requested review from
dellis1972 and
jonpryor
as code owners
grendello
added a commit
that referenced
this pull request
Feb 12, 2025
* main: Bump to dotnet/java-interop@57f7bc84 (#9724) [XABT] Fix Xamarin.Android.Build.Tasks.sln (#9782) [java-runtime, Mono.Android] Use `ApplicationRegistration.Context` (#9779) [Xamarin.Android.Build.Tasks] temporarily support .NET 8 in .NET 10 (#9777) Bump to dotnet/sdk@c0f88f2416 10.0.100-preview.2.25108.4 (#9775) [docs] update dotnetbuilds domain (#9772)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
Android.App.Application.Contextcurrently reads themono.MonoPackageManager.Contextfield, which is set on startup by aContentProvider.mono.MonoPackageManagerdoes not exist in NativeAOT (or CoreCLR), so let's move the field to:net.dot.android.ApplicationRegistration.ContextThe
ApplicationRegistrationclass is already used in NativeAOT, so this can work for all of the runtimes.