[build] SKIP_NUNIT_TESTS check is reversed #950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working with the `Makefile` I noticed this command doesn’t run the tests: ``` $ make run-nunit-tests make: Nothing to be done for `run-nunit-tests’. ``` And this command runs the tests: ``` $ make run-nunit-tests SKIP_NUNIT_TESTS=1 ``` I suspect the intention is that `ifneq` needs to be `ifeq`.
|
@jonathanpeppers, |
Redth
pushed a commit
to Redth/xamarin-android
that referenced
this pull request
Oct 30, 2017
When working with the `Makefile` I noticed this command doesn’t run the tests: ``` $ make run-nunit-tests make: Nothing to be done for `run-nunit-tests’. ``` And this command runs the tests: ``` $ make run-nunit-tests SKIP_NUNIT_TESTS=1 ``` I suspect the intention is that `ifneq` needs to be `ifeq`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with the
MakefileI noticed this command doesn’t run thetests:
And this command runs the tests:
I suspect the intention is that
ifneqneeds to beifeq.I believe this was introduced in 385699a.