AndroidClientHandler handling request content #92
+55
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @danielcaceresm, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@danielcaceresm, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| HttpURLConnection httpConnection = await SetupRequestInternal (request, java_connection).ConfigureAwait (false); | ||
| return await ProcessRequest (request, httpConnection, cancellationToken); | ||
| var java_url = new URL (request.RequestUri.ToString ()); | ||
| var java_connection = java_url.OpenConnection (); |
Contributor
There was a problem hiding this comment.
Please use the full type instead of var here - it helps when viewing the code from outside an IDE
Contributor
|
@danielcaceresm please squash all the commits into one, thanks! |
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 8, 2016
One public method in AndroidClientHandler was modified and one public constructor removed from AndroidHttpResponseMessage. Putting them back requires restoring some of the previous async internal calls.
jonpryor
pushed a commit
that referenced
this pull request
Jul 8, 2016
radical
pushed a commit
that referenced
this pull request
May 8, 2018
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=44530 Basically this is part of the problems reported at https://bugzilla.xamarin.com/show_bug.cgi?id=44263 In good old jar2xml era, we marked "obfuscated" types at jar2xml so that those types are not generated in the API XML. class-parse is not that clever and generates everything as is. We could make changes to api-xml-adjuster to bring back sanity, but instead of doing it in jar2xml, we had better bring in flexibility to obfuscation marking. That is - - If there is obfuscated='false' attribute specification by API metadata fixup, then do not mark as obfuscated in any case. - If not, process any lowercase-named types and nested types as obfuscated, such as 'a', 'SomeType$a', or 'SomeType$b$a'. Due to code structures, we cannot take the same code path as jar2xml (we don't hold list of sibling classes when processing an XML element). https://github.com/xamarin/jar2xml/blob/3a7c404/JavaPackage.java#L78 Also, we had seen some obfuscated types like b$a as NOT marked as obfuscated in the past, because we were checking only a,aa,aaa,aaaa and aaaaa as the parent type for nested types. That should be fixed. To fix this issue, we process marking as part of StripNonBindables(). Also, it was too early to register those types to SymbolTable before stripping those types out, so changed relevant processing order. Fixing bug #44263 then exposed another problem; StripNonBindables() was not complete and it was not processing nested C# types at all. Thus we had generated non-bindable code before. This change fixes this issue at the same time, for fixing the bug. Thus, this will result in "API breakage" looking changes in the end, but the bindings were invalid and should be removed without compatibility concern.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are based on the AndroidClientHandler class before the modifications of #44
I think that my changes are simplier, and the commented race condition, doesn't exists.
Other change I've made is to move the connection reference to the response class, this approach is better than holding the last connection in the handler. On the other hand, is pending to implement, dispose the connection if it fails while connecting.