[xa-prep-tasks] DownloadUri needs to create directory
#884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context in dotnet#880 Since we are now downloading the bundle to `~/android-archives`, it is possible that the directory will not exist on a clean machine. We should be calling `Directory.CreateDirectory` in the `DownloadUri` task anyway, as this could easily happen on any destination file. A case this occured happened on VSTS: https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1006149
|
@jonathanpeppers, |
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Sep 24, 2021
Changes: dotnet/java-interop@8f7ddcd...c936d09 * dotnet/java-interop@c936d09a: [build] Update more NuGet package versions (dotnet#884) * dotnet/java-interop@3f12cd25: Revert "[generator] Remove androidx.annotation from Annotation names (dotnet#882)" * dotnet/java-interop@b37a6478: [build] Bump various NuGets to match related repositories (dotnet#877) * dotnet/java-interop@1e8f5137: [generator] Remove androidx.annotation from Annotation names (dotnet#882)
jonpryor
added a commit
that referenced
this pull request
Sep 24, 2021
Changes: dotnet/java-interop@8f7ddcd...c936d09 * dotnet/java-interop@c936d09a: [build] Update more NuGet package versions (#884) * dotnet/java-interop@3f12cd25: Revert "[generator] Remove androidx.annotation from Annotation names (#882)" * dotnet/java-interop@b37a6478: [build] Bump various NuGets to match related repositories (#877) * dotnet/java-interop@1e8f5137: [generator] Remove androidx.annotation from Annotation names (#882)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context in #880
Since we are now downloading the bundle to
~/android-archives, it ispossible that the directory will not exist on a clean machine. We should
be calling
Directory.CreateDirectoryin theDownloadUritask anyway,as this could easily happen on any destination file.
A case this occured on VSTS:
https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1006149