Skip to content

[Xamarin.Android.Build.Tasks] fix net7.0 "out of support" message #8660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2024
Merged

[Xamarin.Android.Build.Tasks] fix net7.0 "out of support" message #8660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/Sdk/Eol.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Things to note:
</PropertyGroup>
<ItemGroup>
<SdkSupportedTargetPlatformVersion Include="21.0" />
<EolWorkload Include="net6.0-android" Url="https://aka.ms/maui-support-policy" />
<EolWorkload Include="net$(TargetFrameworkVersion.TrimStart('vV'))-android" Url="https://aka.ms/maui-support-policy" />
Copy link
Member Author

@jonathanpeppers jonathanpeppers Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The weird expression here is from the .NET SDK:

https://github.com/dotnet/sdk/blob/208ccf0bffe0a09a2aec8587ce87bf9b357f161d/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.TargetFrameworkInference.targets#L59

</ItemGroup>
<Target Name="_ClearMissingWorkloads">
<!--
Expand Down
6 changes: 3 additions & 3 deletions src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/InvalidConfigTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,16 @@ public void SettingCombinations (bool isRelease, bool useInterpreter, bool publi
}

[Test]
public void EolFrameworks()
public void EolFrameworks ([Values ("net6.0-android", "net7.0-android")] string targetFramework)
{
var library = new XamarinAndroidLibraryProject () {
TargetFramework = "net6.0-android",
TargetFramework = targetFramework,
EnableDefaultItems = true,
};
var builder = CreateApkBuilder ();
builder.ThrowOnBuildFailure = false;
Assert.IsFalse (builder.Restore (library), $"{library.ProjectName} restore should fail");
Assert.IsTrue (StringAssertEx.ContainsText (builder.LastBuildOutput, "NETSDK1202"), $"{builder.BuildLogFile} should have NETSDK1202.");
Assert.IsTrue (StringAssertEx.ContainsText (builder.LastBuildOutput, $"NETSDK1202: The workload '{targetFramework}' is out of support"), $"{builder.BuildLogFile} should have NETSDK1202.");
}

[Test]
Expand Down