Empty commit #8585
Merged
Empty commit #8585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: #8580 Does It Build™? It *should* build, it *used* to build (on 2023-09-02), but #8580 *doesn't* build, as it's trying to reference `android-toolchain/sdk/build-tools/34.0.0/mainDexClasses.rules`, which doesn't exist. Furthermore, AFAICT `xaprepare` uses `$(XABuildToolsVersion)` to specify which build-tools package is installed, which has been `34` since 326ac88, so… how did it build then and why is it failing to build now? What am I missing?
Commit d954ff6 likely should have broken the d17-5 build in the same way that it is currently failing: "/Users/builder/azdo/_work/4/s/xamarin-android/tests/Mono.Android-Tests/Runtime-MultiDex/Mono.Android-TestsMultiDex.csproj" (default target) (32:6) -> (_CompileToDalvik target) -> MSBUILD : java error JAVA0000: Error in /Users/builder/android-toolchain/sdk/build-tools/34.0.0/mainDexClasses.rules: [/Users/builder/azdo/_work/4/s/xamarin-android/tests/Mono.Android-Tests/Runtime-MultiDex/Mono.Android-TestsMultiDex.csproj] MSBUILD : java error JAVA0000: Failed to read file: /Users/builder/android-toolchain/sdk/build-tools/34.0.0/mainDexClasses.rules [/Users/builder/azdo/_work/4/s/xamarin-android/tests/Mono.Android-Tests/Runtime-MultiDex/Mono.Android-TestsMultiDex.csproj] MSBUILD : java error JAVA0000: Compilation failed [/Users/builder/azdo/_work/4/s/xamarin-android/tests/Mono.Android-Tests/Runtime-MultiDex/Mono.Android-TestsMultiDex.csproj] However, I believe builds including d954ff6 succeeded because the build machines likely still had build-tools 32.0.0 packages installed. Our build pools are re-imaged and refreshed somewhat regularly, and they seemingly no longer have build-tools 32.0.0 as we do not provision it. The d17-5 branch does however still provision build tools 30.0.3 for certain tests, and we can hopefully build our test projects with this version to avoid the error highlighted above.
pjcollins
approved these changes
Dec 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #8580
Does It Build™?
It should build, it used to build (on 2023-09-02), but #8580 doesn't build, as it's trying to reference
android-toolchain/sdk/build-tools/34.0.0/mainDexClasses.rules, which doesn't exist.Furthermore, AFAICT
xaprepareuses$(XABuildToolsVersion)to specify which build-tools package is installed, which has been34since 326ac88, so… how did it build then and why is it failing to build now? What am I missing?