[docs] Don't overwrite xml produced by docs build #8451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mdoc export-msxdoc` command that runs at the end of the API docs build shouldn't overwrite the `Mono.Android.xml` file produced by the build.
jonathanpeppers
approved these changes
Oct 24, 2023
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
This looks OK to me. What problem was caused by this, can we put that in the final commit message? It seems like something exporting docs was probably broken.
Member
Author
|
We want to run this step during the regular build, but during the docs build we want to preserve the XML docs that have the additional content. I'll add a note |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mdoc export-msxdoccommand that runs at the end of the API docsbuild shouldn't overwrite the
Mono.Android.xmlfile produced by thebuild.