[profiled-aot] update profile for .NET 8 GA #8428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, I had to update the URL we test, because it was down: https://httpstat.us/200 Instead, I used: https://httpbin.org/status/200 Next, after reviewing the latest methods in the profile, I noticed a lot of timezone logic was completely removed. This might be related to different cookies returns from the new URL, not sure. I added a `DateTime.Now` call to `CommonMethods.cs`, to ensure the timezone logic is in the AOT profile. Testing a `dotnet new android` app on a Pixel 5, an average of 10 runs of the "displayed time`: Average(ms): 179.1 Std Err(ms): 2.53179778023443 Std Dev(ms): 8.00624756049924
jonathanpeppers
added a commit
that referenced
this pull request
Oct 17, 2023
First, I had to update the URL we test, because it was down: https://httpstat.us/200 Instead, I used: https://httpbin.org/status/200 Next, after reviewing the latest methods in the profile, I noticed a lot of timezone logic was completely removed. This might be related to different cookies returns from the new URL, not sure. I added a `DateTime.Now` call to `CommonMethods.cs`, to ensure the timezone logic is in the AOT profile. Testing a `dotnet new android` app on a Pixel 5, an average of 10 runs of the "displayed time`: Average(ms): 179.1 Std Err(ms): 2.53179778023443 Std Dev(ms): 8.00624756049924
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Oct 18, 2023
* main: [Mono.Android] Generate API docs with "full" verbosity (dotnet#8435) [profiled-aot] update profile for .NET 8 GA (dotnet#8428) Bump to xamarin/Java.Interop/main@3c83179 (dotnet#8429) [Xamarin.Android.Build.Tasks] Small refactoring to `AddKeepAlives` method (dotnet#8423) [Xamarin.Android.Build.Tasks] Fixup indirect resource references (dotnet#8416)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, I had to update the URL we test, because it was down:
https://httpstat.us/200
Instead, I used:
https://httpbin.org/status/200
Next, after reviewing the latest methods in the profile, I noticed a lot of timezone logic was completely removed. This might be related to different cookies returns from the new URL, not sure.
I added a
DateTime.Nowcall toCommonMethods.cs, to ensure the timezone logic is in the AOT profile.Testing a
dotnet new androidapp on a Pixel 5, an average of 10 runs of the "displayed time`: