Skip to content

Conversation

@grendello
Copy link
Contributor

@grendello grendello commented Sep 20, 2023

Changes: https://releases.llvm.org/17.0.1/docs/ReleaseNotes.html
Changes: https://releases.llvm.org/17.0.1/tools/lld/docs/ReleaseNotes.html
Changes: dotnet/android-native-tools@83a894f

LLVM 17.0.1 has just been released. For full set of changes in this release
please see the links above. This is the same version of LLVM that is used in
just-released Android NDK r26.

The changes that are relevant to Xamarin.Android are:

  • Typed pointers are no longer supported and the -opaque-pointers
    option has been removed. See the opaque pointers documentation for
    migration instructions.
  • The nofpclass attribute was introduced. This allows more
    optimizations around special floating point value comparisons.

Additionally, Vlad Braeze fixed Unicode process arguments handling on Windows in our gas wrapper.

Changes: https://releases.llvm.org/17.0.1/docs/ReleaseNotes.html
Changes: https://releases.llvm.org/17.0.1/tools/lld/docs/ReleaseNotes.html
Changes: dotnet/android-native-tools@83a894f

LLVM 17.0.1 has just been released.  For full set of changes in this
release please see the links above.  This is the same version of LLVM
that is used in just-released Android NDK r26.

The changes that are relevant to Xamarin.Android are:

    * Typed pointers are no longer supported and the -opaque-pointers
      option has been removed. See the opaque pointers documentation for
      migration instructions.
    * The nofpclass attribute was introduced. This allows more
      optimizations around special floating point value comparisons.

Additionally, Vlad Braeze fixed Unicode process arguments handling on
Windows in our `gas` wrapper.
@grendello grendello requested a review from jonpryor as a code owner September 20, 2023 08:45
@jonpryor
Copy link
Contributor

@grendello: doesn't LLVM Marshal Methods ($(AndroidEnableMarshalMethods)=True) rely on typed pointers? (Or did they use opaque pointers?)

@jonpryor
Copy link
Contributor

LLVM marshal methods uses opaque pointers, and "the -opaque-pointers option has been removed" does not affect us.

@jonpryor jonpryor merged commit 9fcb109 into dotnet:main Sep 20, 2023
@grendello grendello deleted the bump-llvm-toolchain branch September 20, 2023 21:10
grendello added a commit to grendello/xamarin-android that referenced this pull request Sep 21, 2023
* main:
  Bump to xamarin/xamarin-android-tools/main@8a971d9 (dotnet#8353)
  Bump to xamarin/xamarin-android-binutils/L_17.0.1-7.0.0@bd42814 (dotnet#8354)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants