[Xamarin.Android.Build.Tasks] Use Xamarin.Android.Tools.AndroidSdk #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
added
do-not-merge
jonpryor
force-pushed
the
jonp-xamarin-android-tools
branch
2 times, most recently
from
f6e6d30 to
8c5227d
Compare
Contributor
Author
|
macOS+xbuild PR Build #1572 failed because the emulator "hung" on startup, and I killed it. The fact that the build even got that far indicates that this PR largely works, as nothing here should impact on-device behavior. Waiting to merge: dotnet/android-tools#9 |
There is some code which is conceptually, if not literally, duplicated between the xamarin-android and the IDEs (Visual Studio, Visual Studio for Mac), in particular code that deals with finding the Android SDK and Java JDK locations. This code has been split out into a new `xamarin-android-tools` repo to facilitate sharing, without the IDEs needing to submodule xamarin-android, which is quite large. Cleanup the xamarin-android repo to use the new xamarin-android-tools repo for Android SDK information/etc.
jonpryor
force-pushed
the
jonp-xamarin-android-tools
branch
from
8c5227d to
a9b344a
Compare
dellis1972
approved these changes
Sep 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some code which is conceptually, if not literally, duplicated
between the xamarin-android and the IDEs (Visual Studio,
Visual Studio for Mac), in particular code that deals with finding the
Android SDK and Java JDK locations.
This code has been split out into a new
xamarin-android-toolsrepoto facilitate sharing, without the IDEs needing to submodule
xamarin-android, which is quite large.
Cleanup the xamarin-android repo to use the new xamarin-android-tools
repo for Android SDK information/etc.