[AndroidDependenciesTests] Test both manifest types #8186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the InstallAndroidDependenciesTest test to run against the self hosted Xamarin manifest, as well as Googles v2 manifest. For the default case, we shouldn't override any package versions. The dependency versions we calculate should be present in, and installable from, our manifest. For the Google manifest case, we should override the platform-tools version. Their manifest only ever contains one platform-tools version, and it is updated somewhat regularly causing the test to fail every time it changes.
jonathanpeppers
approved these changes
Jul 13, 2023
dellis1972
approved these changes
Jul 13, 2023
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 13, 2023
* main: [Xamarin.Android.Build.Tasks] per-RID assemblies & typemaps (dotnet#8164) [AndroidDependenciesTests] Test both manifest types (dotnet#8186)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 14, 2023
* main: [Xamarin.Android.Build.Tasks] per-RID assemblies & typemaps (dotnet#8164) [AndroidDependenciesTests] Test both manifest types (dotnet#8186) [AndroidDependenciesTests] Use platform-tools 34.0.4 (dotnet#8184)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 14, 2023
* main: [ci] XA.PublishAllLogs publishes all build logs to build artifacts (dotnet#8189) Bump to xamarin/Java.Interop/main@151b03e (dotnet#8188) [Mono.Android] Use PublicApiAnalyzers to ensure we do not break API. (dotnet#8171) [Xamarin.Android.Build.Tasks] per-RID assemblies & typemaps (dotnet#8164) [AndroidDependenciesTests] Test both manifest types (dotnet#8186) [AndroidDependenciesTests] Use platform-tools 34.0.4 (dotnet#8184)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 17, 2023
* main: LLVM IR code generator refactoring and updates (dotnet#8140) [ci] XA.PublishAllLogs publishes all build logs to build artifacts (dotnet#8189) Bump to xamarin/Java.Interop/main@151b03e (dotnet#8188) [Mono.Android] Use PublicApiAnalyzers to ensure we do not break API. (dotnet#8171) [Xamarin.Android.Build.Tasks] per-RID assemblies & typemaps (dotnet#8164) [AndroidDependenciesTests] Test both manifest types (dotnet#8186) [AndroidDependenciesTests] Use platform-tools 34.0.4 (dotnet#8184)
jonathanpeppers
pushed a commit
that referenced
this pull request
Jul 17, 2023
Updates the InstallAndroidDependenciesTest test to run against the self hosted Xamarin manifest, as well as Googles v2 manifest. For the default case, we shouldn't override any package versions. The dependency versions we calculate should be present in, and installable from, our manifest. For the Google manifest case, we should override the platform-tools version. Their manifest only ever contains one platform-tools version, and it is updated somewhat regularly causing the test to fail every time it changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the InstallAndroidDependenciesTest test to run against the self hosted Xamarin manifest, as well as Googles v2 manifest.
For the default case, we shouldn't override any package versions. The dependency versions we calculate should be present in, and installable from, our manifest.
For the Google manifest case, we should override the platform-tools version. Their manifest only ever contains one platform-tools version, and it is updated somewhat regularly causing the test to fail every time it changes.