[tests] don't set /uses-sdk@android:targetSdkVersion=34 by default
#8138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet@95f4b79 When making API 34 the default in .NET 8, some tests tried to build `net7.0-android` projects with an `AndroidManifest.xml` that contains: <uses-sdk android:targetSdkVersion="34" /> This won't work until we backport API 34 to .NET 7. In general, you shouldn't use `<uses-sdk/>` in .NET 6+ apps as the following MSBuild properties should be used instead: <TargetFramework>net7.0-android33</TargetFramework> <SupportedOSPlatformVersion>21</SupportedOSPlatformVersion> Where `33` is implicit if left out. Let's no longer set `TargetSdkVersion` by default in our MSBuild tests, as this is closer to what customers will do. We also no longer build or test Xamarin.Android in main. I removed places in tests that set `TargetSdkVersion = null` and removed one test that is no longer valid in main/.NET 6+.
dellis1972
approved these changes
Jun 22, 2023
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jun 23, 2023
* main: Bump to google/bundletool@f17ce94a (dotnet#8135) [Xamarin.Android.Build.Tasks] Handle IOException in Aapt2Daemon (dotnet#8130) [tests] don't set `/uses-sdk@android:targetSdkVersion=34` by default (dotnet#8138)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jun 26, 2023
* main: Bump to google/bundletool@f17ce94a (dotnet#8135) [Xamarin.Android.Build.Tasks] Handle IOException in Aapt2Daemon (dotnet#8130) [tests] don't set `/uses-sdk@android:targetSdkVersion=34` by default (dotnet#8138)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 95f4b79
When making API 34 the default in .NET 8, some tests tried to build
net7.0-androidprojects with anAndroidManifest.xmlthat contains:This won't work until we backport API 34 to .NET 7.
In general, you shouldn't use
<uses-sdk/>in .NET 6+ apps as the following MSBuild properties should be used instead:Where
33is implicit if left out.Let's no longer set
TargetSdkVersionby default in our MSBuild tests, as this is closer to what customers will do. We also no longer build or test Xamarin.Android in main.I removed places in tests that set
TargetSdkVersion = nulland removed one test that is no longer valid in main/.NET 6+.