-
Notifications
You must be signed in to change notification settings - Fork 564
[Xamarin.Android.Build.Tasks] introduce Eol.targets for .NET 6 #8047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes: dotnet#8003 Add a new `Eol.targets` file to be imported for `net6.0-android` projects. It contains the necessary/minimal settings to emit the build error: Microsoft.NET.EolTargetFrameworks.targets(35,5): error NETSDK1202: The workload 'android' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/maui-support-policy for more information about the support policy. We will probably need the latest .NET SDK to flow to us, in order to write a test. I could only test locally by editing `.targets` files in the .NET SDK.
08790d7 to
eea3c32
Compare
* main: [Xamarin.Android.Build.Tasks] introduce Eol.targets for .NET 6 (dotnet#8047) [Xamarin.Android.Build.Tasks] Add $(_BindingsToolsLocation) to allow overriding binding tool binaries. (dotnet#8069) [tests] new test for provisioning JDKs (dotnet#8059) Localized file check-in by OneLocBuild Task (dotnet#8065) [AndroidDependenciesTests] Use platform-tools 34.0.3 (dotnet#8062) Bump to xamarin/Java.Interop/main@93c50fe (dotnet#8060) [Xamarin.Android.Build.Tasks] Update XA5300 text (dotnet#8057)
|
The message
doesn't really say that the problem is the "6.0" part, and that the fix is to use .NET 7+ (instead it sounds like we completely dropped support for android) I'm thinking doing something like this for us:
which IMHO makes it a bit clearer what the problem is. |
|
The other message is: So yeah, maybe we do need the version number in there? We would have to ship .NET 6 updates to fix it, though. @rolfbjarne should we consider a change in the .NET SDK instead? |
|
We control the 'android' part here: it's easy enough to change that to 'net6.0-android'. I think it's clear enough that people will understand what's happening. That said, we could always create our own error if we want to and show that instead, and there's no need to update older releases. |
Context: dotnet#8047 (comment) The current error message: Microsoft.NET.EolTargetFrameworks.targets(35,5): error NETSDK1202: The workload 'android' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/maui-support-policy for more information about the support policy. Doesn't say the problem is .NET 6, it sounds like all versions of the `android` workload are out of support. To align with the xamarin-macios team, let's change it to be: The workload 'net6.0-android' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/maui-support-policy for more information about the support policy.
…#8307) Context: #8047 (comment) The current error message: Microsoft.NET.EolTargetFrameworks.targets(35,5): error NETSDK1202: The workload 'android' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/maui-support-policy for more information about the support policy. Doesn't say the problem is .NET 6, it sounds like all versions of the `android` workload are out of support. To align with the xamarin-macios team, let's change it to be: The workload 'net6.0-android' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/maui-support-policy for more information about the support policy.
|
This is currently on the rc1 of .NET 8. Indeed I got confused if Android is dropped, since no version is specified. |
|
Oh I see, net6-android is out of support because MAUI has a different support level? https://dotnet.microsoft.com/en-us/platform/support/policy/maui this isn't a MAUI project so got me confused |

Fixes: #8003
Add a new
Eol.targetsfile to be imported fornet6.0-androidprojects. It contains the necessary/minimal settings to emit the build error:We will probably need the latest .NET SDK to flow to us, in order to write a test. I could only test locally by editing
.targetsfiles in the .NET SDK.