[CI] Allow MSBuild test stages to run in the megapipeline #8033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandel-macaque
requested review from
dellis1972,
jonathanpeppers,
jonpryor and
pjcollins
as code owners
pjcollins
reviewed
May 12, 2023
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/XABuildPaths.cs
Outdated
Show resolved
Hide resolved
pjcollins
reviewed
May 12, 2023
build-tools/automation/yaml-templates/setup-test-environment.yaml
Outdated
Show resolved
Hide resolved
mandel-macaque
commented
May 15, 2023
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/XABuildPaths.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Collins <[email protected]>
This reverts commit 136dac7.
mandel-macaque
force-pushed
the
dev/mandel/correct-co-path
branch
from
4a9e560 to
ca567e6
Compare
pjcollins
changed the title
pjcollins
approved these changes
Jun 8, 2023
Member
pjcollins
left a comment
pjcollins
left a comment
There was a problem hiding this comment.
This should be good to go, this latest test run is green https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7887216&view=results
jpobst
reviewed
Jun 8, 2023
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/DeviceTest.cs
Outdated
Show resolved
Hide resolved
jpobst
approved these changes
Jun 8, 2023
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jun 12, 2023
* main: LEGO: Merge pull request 8119 [build] Bump `$(XABuildToolsVersion)`=34 (dotnet#8118) [Xamarin.Android.Build.Tasks] missing resource error handling (dotnet#8066) [CI] Allow MSBuild test stages to run in the megapipeline (dotnet#8033) [ci] Fix nightly test environment provisioning (dotnet#8113)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes changes required to get the MSBuild tests running in the unified
pipeline. New parameters have been added to the the MSBuild test stage
templates to allow them to run without marking the build as failed if
test issues occur. This was done to ensure that release pipelines that
depend on the unified pipeline can run without being blocked by a known
or intermittent test failure.