Fix stat(1) arguments when running APK tests on Linux #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsushieno
approved these changes
Aug 31, 2017
jonpryor
reviewed
Aug 31, 2017
| <Target Name="_RecordApkSizes" AfterTargets="DeployUnitTestApks"> | ||
| <Delete Files="$(MSBuildThisFileDirectory)..\..\..\TestResult-Mono.Android_Tests-values.csv" Condition=" '$(Configuration)' == 'Debug' " /> | ||
| <Exec Command="stat -f "stat: %z %N" "$(_MonoAndroidTestApkFile)" > $(_MonoAndroidTestApkSizesInput)" /> | ||
| <Exec Command="unzip -l "$(_MonoAndroidTestApkFile)" >> $(_MonoAndroidTestApkSizesInput)" /> |
Contributor
There was a problem hiding this comment.
Doesn't this PR entirely *removethisunzip -l` invocation? Is that desired? (It doesn't seem like it's desired.)
Contributor
Author
There was a problem hiding this comment.
Hmm, curious... I have this line locally
jonpryor
reviewed
Aug 31, 2017
| <Delete Files="$(MSBuildThisFileDirectory)..\..\..\TestResult-Mono.Android_Tests-values.csv" Condition=" '$(Configuration)' == 'Debug' " /> | ||
| <Exec Command="stat -f "stat: %z %N" "$(_MonoAndroidTestApkFile)" > $(_MonoAndroidTestApkSizesInput)" /> | ||
| <Exec Command="unzip -l "$(_MonoAndroidTestApkFile)" >> $(_MonoAndroidTestApkSizesInput)" /> | ||
| <Exec Condition=" '$(HostOS)' != 'Linux' " Command="stat -f "stat: %z %N" "$(_MonoAndroidTestApkFile)" > $(_MonoAndroidTestApkSizesInput)" /> |
Contributor
There was a problem hiding this comment.
This should probably be == 'Darwin'. A (soon-ish!) goal is to be able to run unit tests on Windows, and stat isn't going to work there...
macOS uses *BSD command-line tools which often take different parameters than the Linux ones. This is the case with stat(1) which not only expects different command line parameters but also has different meaning of various format placeholders (in this case %z means "file size in bytes" on macOS but "file time stamp timezone in human readable format"). This fixes stat(1) invocation on Linux.
grendello
force-pushed
the
linux-apk-tests-fix
branch
from
371b149 to
40fd1de
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS uses *BSD command-line tools which often take different parameters
than the Linux ones. This is the case with stat(1) which not only expects
different command line parameters but also has different meaning of various
format placeholders (in this case %z means "file size in bytes" on macOS
but "file time stamp timezone in human readable format").
This fixes stat(1) invocation on Linux.