[Xamarin.Android.Build.Tasks] Insert newlines between types #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dellis1972: How should this best be tested? Would we want a "normal" MSBuild tooling test, which would check for newlines in the output? Or should we update an existing test to set |
Contributor
|
@jonpryor there is already a number of MultiDex tests we can add this check too. |
dellis1972
approved these changes
Aug 26, 2017
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=59036 When building a project with `$(AndroidEnableMultiDex)`=True, an `obj/$(Configuration)/multidex.keep` file is generated, which is a list of Java classes, one per line, which should be placed into the "main" `.dex` file for the application. Unfortunately, commit 6829b7d results in a `multidex.keep` file which places all types onto a single line, instead of one class per line. This results in *breaking* multidex, as when this happens, nothing ensures that the required types are in the main `.dex` file, which could prevent the app from launching on the target device. Fix the `<CreateMultiDexMainDexClassList/>` task by always appending a newline after every type which should be preserved.
jonpryor
force-pushed
the
jonp-fix-multidex.keep
branch
from
d468082 to
13b8f94
Compare
Contributor
Author
|
I updated the |
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Sep 6, 2017
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=59036 When building a project with `$(AndroidEnableMultiDex)`=True, an `obj/$(Configuration)/multidex.keep` file is generated, which is a list of Java classes, one per line, which should be placed into the "main" `.dex` file for the application. Unfortunately, commit 6829b7d results in a `multidex.keep` file which places all types onto a single line, instead of one class per line. This results in *breaking* multidex, as when this happens, nothing ensures that the required types are in the main `.dex` file, which could prevent the app from launching on the target device. Fix the `<CreateMultiDexMainDexClassList/>` task by always appending a newline after every type which should be preserved.
Aguilex
pushed a commit
that referenced
this pull request
Sep 6, 2017
[Xamarin.Android.Build.Tasks] Insert newlines between types (#790)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=59036
When building a project with
$(AndroidEnableMultiDex)=True, anobj/$(Configuration)/multidex.keepfile is generated, which is alist of Java classes, one per line, which should be placed into the
"main"
.dexfile for the application.Unfortunately, commit 6829b7d results in a
multidex.keepfile whichplaces all types onto a single line, instead of one class per line.
This results in breaking multidex, as when this happens, nothing
ensures that the required types are in the main
.dexfile, whichcould prevent the app from launching on the target device.
Fix the
<CreateMultiDexMainDexClassList/>task by always appending anewline after every type which should be preserved.