Use -f flag to xabuild, to turn relative paths absolute
#755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build system dies if xabuild is a symlink pointing to the real xabuild with a *relative* path instead of an absolute one. The `-f` flag to readlink handles this.
Contributor
|
macOS doesn't support |
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Dec 14, 2020
Changes: dotnet/java-interop@99897b2...2f62ffd * dotnet/java-interop@2f62ffd4: [Xamarin.Android.Tools.Bytecode] @not-null androidx.annotation.NonNull (dotnet#759) * dotnet/java-interop@7c1ad51c: [java-source-utils] Properly represent unresolved types (dotnet#758) * dotnet/java-interop@c1bc5c83: [java-source-utils] Better support orphaned Javadocs (dotnet#757) * dotnet/java-interop@0cb8e2d3: [Xamarin.Android.Tools.ApiXmlAdjuster] Use Dictionaries for perf (dotnet#756) * dotnet/java-interop@99f89905: [build] Fix for MSBuild 16.8 (dotnet#755)
jonpryor
added a commit
that referenced
this pull request
Dec 15, 2020
Changes: dotnet/java-interop@99897b2...2f62ffd * dotnet/java-interop@2f62ffd4: [Xamarin.Android.Tools.Bytecode] @not-null androidx.annotation.NonNull (#759) * dotnet/java-interop@7c1ad51c: [java-source-utils] Properly represent unresolved types (#758) * dotnet/java-interop@c1bc5c83: [java-source-utils] Better support orphaned Javadocs (#757) * dotnet/java-interop@0cb8e2d3: [Xamarin.Android.Tools.ApiXmlAdjuster] Use Dictionaries for perf (#756) * dotnet/java-interop@99f89905: [build] Fix for MSBuild 16.8 (#755)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build system dies if xabuild is a symlink pointing to the real xabuild with a relative path instead of an absolute one. The
-fflag to readlink handles this.