Skip to content

Conversation

@pjcollins
Copy link
Member

@pjcollins pjcollins commented Nov 2, 2022

Context: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/codeql/codeql-semmle

CodeQL static analysis has been added to our nightly build job. This
tool dramatically increases build times, and for complex builds like
xamarin-android it should run in a separate pipeline that is not time
sensitive. CodeQL will only run against commits to the main branch.

@pjcollins
Copy link
Member Author

@pjcollins pjcollins changed the title Test enabling CodeQL [ci] Enable CodeQL on nightly build Nov 10, 2022
@pjcollins
Copy link
Member Author

pjcollins commented Nov 10, 2022

The nightly run looks like it finally completed successfully (after four hours), I'm going to bump the build job timeout again.

@pjcollins pjcollins marked this pull request as ready for review November 10, 2022 23:29
@pjcollins pjcollins requested a review from jonpryor as a code owner November 10, 2022 23:29
@pjcollins pjcollins merged commit acfc1ef into main Nov 11, 2022
@pjcollins pjcollins deleted the dev/pjc/cql branch November 11, 2022 17:34
grendello added a commit to grendello/xamarin-android that referenced this pull request Nov 14, 2022
* main:
  [ci] Enable CodeQL on nightly build (dotnet#7522)
  Bump to xamarin/Java.Interop/main@984711a (dotnet#7545)
  [Xamarin.Android.Build.Tasks] Timing.xml & `android:exported="true"` (dotnet#7551)
  [Xamarin.Android.Build.Tasks] run a Clean if the project path changes. (dotnet#7476)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants