[xaprepare] CGManifest.json conforms to JSON schema #7342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://www.jsonschemavalidator.net/ Context: https://github.com/JamieMagee/verify-cgmanifest Context: https://json.schemastore.org/component-detection-manifest.json Context: dotnet/android-libraries#608 There is a [JSON Schema][0] for `CGManifest.json`. Update `xaprepare` so that `CGManifest.json` conforms to the JSON schema. This involves three sets of changes: * Add a `$schema` property. * Add a `version` property; I can't find any actual documentation for this schema, but the [sample manifest][1] uses `"version": 1`, so use the same version. * "camelCase" all the JSON property names. From the [JamieMagee/verify-cgmanifest README.md][2]: > Component Detection will accept object properties in PascalCase, > but JSON schema does not have a case-insensitive mode. > Camel case is the most common way to write object properties in > JSON. With these changes, our generated `bin/Build$(Configuration)/CGManifest.json` reports no errors when using <https://www.jsonschemavalidator.net>. [0]: https://json.schemastore.org/component-detection-manifest.json [1]: https://github.com/JamieMagee/verify-cgmanifest/blob/2adfb450cd1f2170c3df120036f4a531285167ef/cgmanifest.sample.json [2]: https://github.com/JamieMagee/verify-cgmanifest/blob/2adfb450cd1f2170c3df120036f4a531285167ef/README.md
jonpryor
force-pushed
the
jonp-validate-cgmanifest.json
branch
from
034f911 to
11012bc
Compare
grendello
approved these changes
Sep 6, 2022
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Sep 7, 2022
* main: Bump to dotnet/installer@330dee3 (dotnet#7334) [xaprepare] CGManifest.json conforms to JSON schema (dotnet#7342)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Sep 7, 2022
* mm-runtime: Bump to dotnet/installer@330dee3 (dotnet#7334) [xaprepare] CGManifest.json conforms to JSON schema (dotnet#7342)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Sep 7, 2022
* mm-cleanup-and-enable: Bump to dotnet/installer@330dee3 (dotnet#7334) [xaprepare] CGManifest.json conforms to JSON schema (dotnet#7342)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://www.jsonschemavalidator.net/
Context: https://github.com/JamieMagee/verify-cgmanifest
Context: https://json.schemastore.org/component-detection-manifest.json
Context: dotnet/android-libraries#608
There is a JSON Schema for
CGManifest.json.Update
xaprepareso thatCGManifest.jsonconforms to the JSONschema. This involves three sets of changes:
Add a
$schemaproperty.Add a
versionproperty; I can't find any actual documentationfor this schema, but the sample manifest uses
"version": 1,so use the same version.
"camelCase" all the JSON property names. From the
JamieMagee/verify-cgmanifest README.md:
With these changes, our generated
bin/Build$(Configuration)/CGManifest.jsonreports no errors whenusing https://www.jsonschemavalidator.net.