Skip to content

Conversation

@pjcollins
Copy link
Member

@pjcollins pjcollins commented Aug 30, 2022

The signing steps that run on macOS to prepare a PKG for notarization
have been slow and are frequently failing. Attempt to fix this by
splitting up the files we send to ESRP on macOS into multiple batches to
hopefully put less pressure on the service.

A signClassicPkgContent parameter has also been added to allow us to
skip these steps while testing, or when building .NET release branches if
needed.

MicroBuild tooling has also been updated to the latest versions.

@pjcollins
Copy link
Member Author

pjcollins commented Aug 30, 2022

This seems a little better, though we may want to further split up the set of binutils lib files. That can happen in the future if needed.

image

@pjcollins
Copy link
Member Author

Testing this a second time to see if the notarization stage succeeds: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6625844&view=results

@pjcollins pjcollins marked this pull request as ready for review August 30, 2022 17:22
@pjcollins pjcollins requested a review from jonpryor as a code owner August 30, 2022 17:22
The signing steps that run on macOS to prepare a PKG for notarization
have been slow and are frequently failing.  Attempt to fix this by
splitting up the files we send to ESRP on macOS into multiple batches to
hopefully put less pressure on the service.
@pjcollins
Copy link
Member Author

@pjcollins pjcollins merged commit 7c9c24b into main Aug 30, 2022
@pjcollins pjcollins deleted the sign-debug branch August 30, 2022 22:05
pjcollins added a commit that referenced this pull request Aug 30, 2022
The signing steps that run on macOS to prepare a PKG for notarization
have been slow and are frequently failing.  Attempt to fix this by
splitting up the files we send to ESRP on macOS into multiple batches to
hopefully put less pressure on the service.

A `signClassicPkgContent` parameter has also been added to allow us to
skip these steps while testing, or when building .NET release branches if
needed.

MicroBuild tooling has also been updated to the latest versions.
grendello added a commit to grendello/xamarin-android that referenced this pull request Aug 31, 2022
* main:
  [ci] Split up signing for files to be notarized (dotnet#7321)
  [ci] Add support to net7.0 for multi-targeting in VS (dotnet#7311)
  [ci] Skip classic tests on .NET release branches (dotnet#7312)
  [tests] Use `$(AndroidSdkPlatformToolsVersion)`=33.0.3 (dotnet#7320)
  Bump to xamarin/java.interop/main@4f813cb2 (dotnet#7308)
  Bump to mono/mono.posix@d8994ca, dotnet/android-libzipsharp@98e9173 (dotnet#7309)
grendello added a commit to grendello/xamarin-android that referenced this pull request Aug 31, 2022
* mm-runtime:
  [ci] Split up signing for files to be notarized (dotnet#7321)
  [ci] Add support to net7.0 for multi-targeting in VS (dotnet#7311)
  [ci] Skip classic tests on .NET release branches (dotnet#7312)
  [tests] Use `$(AndroidSdkPlatformToolsVersion)`=33.0.3 (dotnet#7320)
  Bump to xamarin/java.interop/main@4f813cb2 (dotnet#7308)
  Bump to mono/mono.posix@d8994ca, dotnet/android-libzipsharp@98e9173 (dotnet#7309)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants