-
Notifications
You must be signed in to change notification settings - Fork 565
[build] disable <XamarinTelemetry/> task
#7275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1585820 Context: xamarin/XamarinVS#13271 Many of our MSBuild tests fail with: error MSB4018: The "XamarinTelemetry" task failed unexpectedly. error MSB4018: System.IO.FileNotFoundException: Could not load file or assembly 'Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' or one of its dependencies. The system cannot find the file specified. error MSB4018: File name: 'Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' error MSB4018: at Microsoft.VisualStudio.Telemetry.TelemetrySessionSettings.GetFaultEventBucketFilterJson(List`1 bucketFilters) error MSB4018: at Microsoft.VisualStudio.Telemetry.TelemetrySessionSettings.ToString() error MSB4018: at Microsoft.VisualStudio.Telemetry.TelemetrySession.SerializeSettings() error MSB4018: at Xamarin.Common.Tasks.Telemetry.GetSession(IBuildEngine4 buildEngine, String vsTelemetrySession) in D:\a\_work\1\s\src\MSBuild\Xamarin.Common.Tasks\Telemetry.cs:line 62 error MSB4018: at Xamarin.Common.Tasks.XamarinTelemetry.Execute() in D:\a\_work\1\s\src\MSBuild\Xamarin.Common.Tasks\XamarinTelemetry.cs:line 31 error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() error MSB4018: WRN: Assembly binding logging is turned OFF. error MSB4018: To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1. error MSB4018: Note: There is some performance penalty associated with assembly bind failure logging. error MSB4018: To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog]. It appears there is a fix in XamarinVS for this. In order to get our CI working, it appears we can set `%_WriteTelemetryProperties%` to `false` for now to workaround it: https://github.com/xamarin/XamarinVS/blob/d31703e0163cd3db24e874146c41988f64fac737/src/MSBuild/Xamarin/Xamarin.Sdk.targets#L82
Member
Author
|
These already looks "greener" than main: The one lane that failed hit: |
pjcollins
approved these changes
Aug 17, 2022
jonathanpeppers
added a commit
that referenced
this pull request
Aug 17, 2022
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1585820 Context: xamarin/XamarinVS#13271 Visual Studio 17.3.0 introduced a new [`_WriteTelemetryProperties`][0] target into `Xamarin.Sdk.targets`: <Target Name="_WriteTelemetryProperties" DependsOnTargets="_CollectAndroidTelemetryProperties;_CollectIOSTelemetryProperties" AfterTargets="Build" Condition="'$(_WriteTelemetryProperties)' != 'false'"> Unfortunately, this new target uses a new `<XamarinTelemetry/>` task which fails on CI, which impacts many of our MSBuild unit tests: error MSB4018: The "XamarinTelemetry" task failed unexpectedly. error MSB4018: System.IO.FileNotFoundException: Could not load file or assembly 'Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' or one of its dependencies. The system cannot find the file specified. error MSB4018: File name: 'Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' error MSB4018: at Microsoft.VisualStudio.Telemetry.TelemetrySessionSettings.GetFaultEventBucketFilterJson(List`1 bucketFilters) error MSB4018: at Microsoft.VisualStudio.Telemetry.TelemetrySessionSettings.ToString() error MSB4018: at Microsoft.VisualStudio.Telemetry.TelemetrySession.SerializeSettings() error MSB4018: at Xamarin.Common.Tasks.Telemetry.GetSession(IBuildEngine4 buildEngine, String vsTelemetrySession) in D:\a\_work\1\s\src\MSBuild\Xamarin.Common.Tasks\Telemetry.cs:line 62 error MSB4018: at Xamarin.Common.Tasks.XamarinTelemetry.Execute() in D:\a\_work\1\s\src\MSBuild\Xamarin.Common.Tasks\XamarinTelemetry.cs:line 31 error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() error MSB4018: WRN: Assembly binding logging is turned OFF. error MSB4018: To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1. error MSB4018: Note: There is some performance penalty associated with assembly bind failure logging. error MSB4018: To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog]. It appears that this will be fixed in Visual Studio 17.3.1. In the meantime, fix our CI by *disabling* telemetry, by setting the `%_WriteTelemetryProperties%` env var to `false`.
|
I think the issue comes from the fact that there is no |
Member
Author
|
Actually the assembly version of the dll inside the package is 13.0.0.0, I checked it today.
… On Aug 17, 2022, at 5:49 PM, Amr ***@***.***> wrote:
I think the issue comes from the fact that there is no Newtonsoft.Json with the version 13.0.0.0. The closest version on NuGet is 13.0.1.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1585820
Context: https://github.com/xamarin/XamarinVS/pull/13271
Many of our MSBuild tests fail with:
It appears there is a fix in XamarinVS for this.
In order to get our CI working, it appears we can set
%_WriteTelemetryProperties%tofalsefor now to workaround it:https://github.com/xamarin/XamarinVS/blob/d31703e0163cd3db24e874146c41988f64fac737/src/MSBuild/Xamarin/Xamarin.Sdk.targets#L82