[Mono.Android] API-26 Enumification (#662) #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=30909 Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=51293 Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=55473 Bump to xamarin-android-api-compatibility/master/6fe9b17f. Add `Documentation/HowToAddNewApiLevel.md`, to describe the process for binding new API levels, including enumification. Enumify API-26. Update `build-tools/enumification-helpers` to support the latest droiddoc `packages.html` format. API-26 changed `Activity.findViewById(int)` to be a generic method. Remove the `<typeParameters/>` element and "fix" the return type so that we don't break API compatibility, as `generator` doesn't currently do anything sane here. (Specifically, all generic paramaters are currently bound as `Java.Lang.Object`, *even if* the type parameter has a constraint which provides a more specific type!) Fix binding of `Java.Nio.FileChannel` so it can be actually bound, related `SeekableByteChannel` support fixes. Remove `//implements[@name='AutoCloseable']` and `//implements[@name='Destryable']`, as they add Java `default` interface methods which can't be sanely supported at this time. Update `api-merge` to change `default` interface methods to non-`default` methods when merging with an older API level which contained the non-`default` interface method. This preserves backward compatibility with existing assemblies and source code. Remove the associated workarounds. Bump xamarin-android-api-compatibility to check against the latest-and-greatest API-26 binding.
Contributor
Author
|
build |
jonpryor
pushed a commit
that referenced
this pull request
Oct 20, 2020
Fixes: dotnet/java-interop#461 Fixes: dotnet/java-interop#682 Fixes: dotnet/java-interop#717 Fixes: dotnet/java-interop#719 Fixes: dotnet/java-interop#728 Changes: dotnet/java-interop@ac914ce...b991bb8 * dotnet/java-interop@b991bb86: [generator] Revert change to use auto-properties in EventArgs classes (#736) * dotnet/java-interop@ee50d89b: Bump to xamarin/xamarin-android-tools/master@f2af06f2 (#733) * dotnet/java-interop@a0b895c1: [build] Suppress NuGet warnings (#730) * dotnet/java-interop@8b1b0507: [generator] Fix parsing of complex generic types (#729) * dotnet/java-interop@ee7afeed: [generator] Prevent generating duplicate EventArgs classes (#726) * dotnet/java-interop@1f21f38c: [generator] Use GC.KeepAlive for reference type method parameters. (#725) * dotnet/java-interop@5136ef98: [Xamarin.Android.Tools.Bytecode] Hide Kotlin nested types inside (#723) * dotnet/java-interop@53d60513: [jnimarshalmethod-gen] Fix registration on Windows (#721) * dotnet/java-interop@5a834d42: [jnimarshalmethod-gen] Avoid creating AppDomains (#720) * dotnet/java-interop@a76edb8c: [Xamarin.Android.Tools.ApiXmlAdjuster] Find app.android.IntentService (#718) * dotnet/java-interop@6cde0877: [Java.Interop] Emit a reference assembly for Java.Interop.dll (#716) * dotnet/java-interop@b858dc59: [generator] Provide line/col numbers for api.xml warnings (#715) * dotnet/java-interop@9be92a04: [ci] Don't kick off CI for documentation only changes. (#712) * dotnet/java-interop@03c22722: [jnimarshalmethod-gen] Fix type resolution crash (#706)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=30909
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=51293
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=55473
Bump to xamarin-android-api-compatibility/master/6fe9b17f.
Add
Documentation/HowToAddNewApiLevel.md, to describe the processfor binding new API levels, including enumification.
Enumify API-26.
Update
build-tools/enumification-helpersto support the latestdroiddoc
packages.htmlformat.API-26 changed
Activity.findViewById(int)to be a generic method.Remove the
<typeParameters/>element and "fix" the return type sothat we don't break API compatibility, as
generatordoesn'tcurrently do anything sane here. (Specifically, all generic
paramaters are currently bound as
Java.Lang.Object, even if thetype parameter has a constraint which provides a more specific type!)
Fix binding of
Java.Nio.FileChannelso it can be actually bound,related
SeekableByteChannelsupport fixes.Remove
//implements[@name='AutoCloseable']and//implements[@name='Destryable'], as they add Javadefaultinterface methods which can't be sanely supported at this time.
Update
api-mergeto changedefaultinterface methods tonon-
defaultmethods when merging with an older API level whichcontained the non-
defaultinterface method. This preserves backwardcompatibility with existing assemblies and source code. Remove the
associated workarounds.
Bump xamarin-android-api-compatibility to check against the
latest-and-greatest API-26 binding.