Skip to content

[apksigner] Remove AdditionalProperties on java-source-utils.csproj #7157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2022
Merged

[apksigner] Remove AdditionalProperties on java-source-utils.csproj #7157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a44033
Try things
jonpryor Jul 7, 2022
52eacd0
Try xamarin/java.interop#1007
jonpryor Jul 7, 2022
9ca6b1b
Bump to xamarin/java.interop/main@c942ab68
jonpryor Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion external/Java.Interop
Open in desktop
Submodule Java.Interop updated from 7716ae to c942ab
2 changes: 1 addition & 1 deletion src/apksigner/apksigner.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<ItemGroup>
<!-- There isn't an actual dependency here, but we can only build one 'gradlew' project
at a time, and adding <ProjectReference> between them ensures they run sequentially. -->
<ProjectReference Include="..\..\external\Java.Interop\tools\java-source-utils\java-source-utils.csproj" ReferenceOutputAssembly="False" SkipGetTargetFrameworkProperties="True" AdditionalProperties="TargetFramework=$(DotNetTargetFramework)" />
<ProjectReference Include="..\..\external\Java.Interop\tools\java-source-utils\java-source-utils.csproj" ReferenceOutputAssembly="False" />
Copy link
Contributor Author

@jonpryor jonpryor Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpobst wrote:

i'm not sure about removing SkipGetTargetFrameworkProperties="True", i think that is to ignore the fact that apksigner is ns2.0, and it's trying to reference a net7.0 java-source-utils project
might need to make java-source-utils be ns2.0

Looks like it built! ¯\(ツ)/¯

</ItemGroup>

<Import Project="apksigner.targets" />
Expand Down