[Xamarin.Android.Build.Tasks] fix @(LibraryProjectZip) and NuGets #7151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: xamarin/GooglePlayServicesComponents#652 In .NET 6, `@(AndroidLibrary)` defaults to `%(Pack)` being true, while `@(LibraryProjectZip)` mistakenly does not. This would be an issue if you migrated a project using `@(LibraryProjectZip)` and were not relying on the default wildcards that would use: <AndroidLibrary Include="**/*.aar" /> Let's set this value by default, to ease migration to .NET 6. I updated a test for this scenario and fixed some assertions that are working since 2ca2a10 was merged.
jpobst
approved these changes
Jul 5, 2022
dellis1972
approved these changes
Jul 6, 2022
Contributor
Context: https://github.com/xamarin/GooglePlayServicesComponents/issues/652
In .NET 6, `@(AndroidLibrary.Pack)` defaults to true (97190b6c), while
`%(LibraryProjectZip.Pack)` was never set, and thus was false. This
would be an issue if you migrated a project using `@(LibraryProjectZip)` and were
not relying on the default wildcards used by:
<AndroidLibrary Include="**/*.aar" />
The result is that `.aar` files weren't included into the `.nupkg`,
which would result in subsequent build & packaging errors when
using the `.nupkg`, as the `.aar` was missing.
Set `%(LibraryProjectZip.Pack)`=True by default in .NET 6+, to ease
project migration from Classic Xamarin.Android to .NET 6.
I updated a test for this scenario and fixed some assertions that are
working since 2ca2a103 was merged. |
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Jul 26, 2022
…tnet#7151) Context: xamarin/GooglePlayServicesComponents#652 In .NET 6, `@(AndroidLibrary.Pack)` defaults to true (97190b6), while `%(LibraryProjectZip.Pack)` was never set, and thus was false. This would be an issue if you migrated a project using `@(LibraryProjectZip)` and were not relying on the default wildcards used by: <AndroidLibrary Include="**/*.aar" /> The result is that `.aar` files weren't included into the `.nupkg`, which would result in subsequent build & packaging errors when using the `.nupkg`, as the `.aar` was missing. Set `%(LibraryProjectZip.Pack)`=True by default in .NET 6+, to ease project migration from Classic Xamarin.Android to .NET 6. I updated a test for this scenario and fixed some assertions that are working since 2ca2a10 was merged.
jonathanpeppers
added a commit
that referenced
this pull request
Aug 1, 2022
) Backport: #7151 Context: xamarin/GooglePlayServicesComponents#652 In .NET 6, `@(AndroidLibrary.Pack)` defaults to true (97190b6), while `%(LibraryProjectZip.Pack)` was never set, and thus was false. This would be an issue if you migrated a project using `@(LibraryProjectZip)` and were not relying on the default wildcards used by: <AndroidLibrary Include="**/*.aar" /> The result is that `.aar` files weren't included into the `.nupkg`, which would result in subsequent build & packaging errors when using the `.nupkg`, as the `.aar` was missing. Set `%(LibraryProjectZip.Pack)`=True by default in .NET 6+, to ease project migration from Classic Xamarin.Android to .NET 6. I updated a test for this scenario and fixed some assertions that are working since 2ca2a10 was merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: xamarin/GooglePlayServicesComponents#652
In .NET 6,
@(AndroidLibrary)defaults to%(Pack)being true, while@(LibraryProjectZip)mistakenly does not. This would be an issue ifyou migrated a project using
@(LibraryProjectZip)and were notrelying on the default wildcards that would use:
Let's set this value by default, to ease migration to .NET 6.
I updated a test for this scenario and fixed some assertions that are
working since 2ca2a10 was merged.