[tests] How does InstallAndroidDependencies *pass*? #7081
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#7073 Context: dotnet#7073 (comment) How does `InstallAndroidDependenciesTest()` pass?! Let's Find Out?
Contributor
Author
|
|
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jun 9, 2022
Context: dotnet#7081 Context: dotnet#7073 (comment) Trying to figure out why the `InstallAndroidDependenciesTest()` is failing. My *guess* is that `monodroid-config.xml` exists, causing the `$(_AndroidSdkPath)` output property to use a *system-wide* installation path, instead of the desired `$(AndoridSdkDirectory)` input value. PR dotnet#7081 tested behavior against main, and determined that `monodroid-config.xml` doesn't exist, which may be why this test passes on main. Update dotnet#7073 to also assert the (non-?)existence of `monodroid-config.xml`. If it *does* exist, this would explain why it's failing. *If* it's failing because of `monodroid-config.xml`, the next question becomes *why* it exists. Update `BaseTest.TestSetup()` to assert that it doesn't exist; when it does exist, tests will begin failing.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jun 10, 2022
Context: dotnet#7081 Context: dotnet#7073 (comment) Trying to figure out why the `InstallAndroidDependenciesTest()` is failing. My *guess* is that `monodroid-config.xml` exists, causing the `$(_AndroidSdkPath)` output property to use a *system-wide* installation path, instead of the desired `$(AndoridSdkDirectory)` input value. PR dotnet#7081 tested behavior against main, and determined that `monodroid-config.xml` doesn't exist, which may be why this test passes on main. Update dotnet#7073 to also assert the (non-?)existence of `monodroid-config.xml`. If it *does* exist, this would explain why it's failing. *If* it's failing because of `monodroid-config.xml`, the next question becomes *why* it exists. Update `BaseTest.TestSetup()` to assert that it doesn't exist; when it does exist, tests will begin failing.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
How does `ValidateAndroidSdkLocation()` accept a (what should be) empty directory?
jonpryor
force-pushed
the
jonp-check-InstallAndroidDependencies
branch
from
1f20b64 to
0e29341
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #7073
Context: #7073 (comment)
How does
InstallAndroidDependenciesTest()pass?!Let's Find Out?