-
Notifications
You must be signed in to change notification settings - Fork 564
Add .NET 6+ template for Android wear #7013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jonathanpeppers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Microsoft.Android.Templates/android-wear/AndroidApp1.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Android.Templates/android-wear/AndroidManifest.xml
Outdated
Show resolved
Hide resolved
src/Microsoft.Android.Templates/android-wear/Resources/values/strings.xml
Outdated
Show resolved
Hide resolved
jonathanpeppers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM 👍
|
The fundamental question is, do we actually want to provide a template for Wear at all? Providing a template implies that it's "fit for purpose", is tested, is maintained, will continue to work. Which, for starters, implies that we'd have a "WearOS 'device'" that we use as a target, as we do with Android emulators now. Do we want to actually do that? VSMac used to have a Wear template. VSMac 17 does not have a Wear template. I suspect VSWin should go the same way (remove the template), and I'm not entirely certain that we want to provide a template either. |
|
A test fails: |
Had to ignore these warnings in the test. It the |
|
@jonpryor is it worth me adding a test step to install and run the WearOS emulator and run a test on it? It works locally for me, so we could actually start testing at least the template on the emulator during CI? |
Yes. Yes it is. If we provide this template at all (see also), then we're implicitly/explicitly stating that the template is supported and works. Consequently, we should ensure that this runs as expected on a WearOS emulator for testing. |
jonathanpeppers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we get to a point we want to merge this, we should use the updated .NET-branded app icons here: #7065
8648199 to
3ebdec5
Compare
Icons have been updated 👍 |
src/Microsoft.Android.Templates/android-wear/AndroidManifest.xml
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
d04b8eb to
a95fe6f
Compare
Fixes dotnet#7003 This speaks for itself, lets add a template for Wear applications.
Context: #7003 Add .NET 6+ template for Android Wear OS, creatable as: dotnet new androidwear Additionally, add a `wear_tests` stage to `azure-pipelines.yaml` which creates a Wear OS emulator, and runs the Android Wear template on the Wear OS emulator to ensure that the template works.
Fixes #7003
This speaks for itself, lets add a template for Wear applications.