Skip to content

Conversation

@dellis1972
Copy link
Contributor

Fixes #7003

This speaks for itself, lets add a template for Wear applications.

@dellis1972 dellis1972 requested a review from jonpryor as a code owner May 19, 2022 10:04
@dellis1972 dellis1972 marked this pull request as draft May 19, 2022 12:21
@dellis1972 dellis1972 marked this pull request as ready for review May 19, 2022 12:59
@dellis1972 dellis1972 requested review from jonathanpeppers and removed request for jonpryor May 19, 2022 12:59
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM 👍

@jonpryor
Copy link
Contributor

The fundamental question is, do we actually want to provide a template for Wear at all?

Providing a template implies that it's "fit for purpose", is tested, is maintained, will continue to work.

Which, for starters, implies that we'd have a "WearOS 'device'" that we use as a target, as we do with Android emulators now.

Do we want to actually do that?

VSMac used to have a Wear template. VSMac 17 does not have a Wear template. I suspect VSWin should go the same way (remove the template), and I'm not entirely certain that we want to provide a template either.

@jonathanpeppers
Copy link
Member

A test fails:

  Failed DotNetNew("androidwear") [1 m 1 s]
  Error Message:
     /Users/runner/work/1/a/TestRelease/05-19_15.06.09/temp/DotNetNewandroidwear/build.log should have no MSBuild warnings.

@dellis1972
Copy link
Contributor Author

A test fails:

  Failed DotNetNew("androidwear") [1 m 1 s]
  Error Message:
     /Users/runner/work/1/a/TestRelease/05-19_15.06.09/temp/DotNetNewandroidwear/build.log should have no MSBuild warnings.

Had to ignore these warnings in the test. It the XA4218 which is where we look up the uses-library stuff from an AndroidManifest in a library and check the sdk directory for them. In this case these files do not exists so we end up with this XA4218 warning.

@dellis1972
Copy link
Contributor Author

@jonpryor is it worth me adding a test step to install and run the WearOS emulator and run a test on it? It works locally for me, so we could actually start testing at least the template on the emulator during CI?

@jonpryor
Copy link
Contributor

@dellis1972 asked:

is it worth me adding a test step to install and run the WearOS emulator and run a test on it?

Yes. Yes it is. If we provide this template at all (see also), then we're implicitly/explicitly stating that the template is supported and works. Consequently, we should ensure that this runs as expected on a WearOS emulator for testing.

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we get to a point we want to merge this, we should use the updated .NET-branded app icons here: #7065

@dellis1972 dellis1972 force-pushed the Issue7003 branch 3 times, most recently from 8648199 to 3ebdec5 Compare June 7, 2022 14:06
@dellis1972
Copy link
Contributor Author

If we get to a point we want to merge this, we should use the updated .NET-branded app icons here: #7065

Icons have been updated 👍

@dellis1972
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dellis1972 dellis1972 force-pushed the Issue7003 branch 2 times, most recently from d04b8eb to a95fe6f Compare June 22, 2022 13:30
Fixes dotnet#7003

This speaks for itself, lets add a template for Wear applications.
@jonpryor jonpryor merged commit e4fd84a into dotnet:main Jul 5, 2022
@dellis1972 dellis1972 deleted the Issue7003 branch July 11, 2022 14:09
jonathanpeppers pushed a commit that referenced this pull request Jul 15, 2022
Context: #7003

Add .NET 6+ template for Android Wear OS, creatable as:

	dotnet new androidwear

Additionally, add a `wear_tests` stage to `azure-pipelines.yaml`
which creates a Wear OS emulator, and runs the Android Wear template
on the Wear OS emulator to ensure that the template works.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WearOS app fails to compile when targeting net6.0-android

3 participants