Bump to xamarin/java.interop/main@4787e017 #6984
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
force-pushed
the
jonp-try-ji-975
branch
2 times, most recently
from
46183c2 to
9226926
Compare
jonpryor
changed the title
jonpryor
added a commit
to jonpryor/java.interop
that referenced
this pull request
May 6, 2022
Context: dotnet/android#6984 While attempting to bump Java.Interop, the **nunit Java.Interop tests** job is failing on Windows, because it can't find `jcw-gen.dll`: C:\a\_work\2\s\external\Java.Interop\tests\Java.Base-Tests\Java.Base-Tests.targets(27,5): error MSB3073: The command "C:\a\_work\2\s\bin\Release\dotnet\dotnet "C:\a\_work\2\s\external\Java.Interop\bin\Release-net6.0\/jcw-gen.dll" …"" exited with code 1. The `jcw-gen.dll` invocation needs to use `$(UtilityOutputFullPath)`, not `$(ToolOutputFullPath)`, as the `jcw-gen.dll` output path is altered within xamarin/xamarin-android. `$(UtilityOutputFullPath)` allows customization by xamarin-android, not `$(ToolOutputFullPath)`.
jonpryor
added a commit
to dotnet/java-interop
that referenced
this pull request
May 6, 2022
Context: dotnet/android#6984 While attempting to bump Java.Interop, the **nunit Java.Interop tests** job is failing on Windows, because it can't find `jcw-gen.dll`: C:\a\_work\2\s\external\Java.Interop\tests\Java.Base-Tests\Java.Base-Tests.targets(27,5): error MSB3073: The command "C:\a\_work\2\s\bin\Release\dotnet\dotnet "C:\a\_work\2\s\external\Java.Interop\bin\Release-net6.0\/jcw-gen.dll" …"" exited with code 1. The `jcw-gen.dll` invocation needs to use `$(UtilityOutputFullPath)`, not `$(ToolOutputFullPath)`, as the `jcw-gen.dll` output path is altered within xamarin/xamarin-android. `$(UtilityOutputFullPath)` allows customization by xamarin-android, not `$(ToolOutputFullPath)`.
Changes: dotnet/java-interop@2a882d2...843f3c7 * dotnet/java-interop@843f3c78: [Java.Base-Tests] Use $(UtilityOutputFullPath)/jcw-gen.dll (#979) * dotnet/java-interop@4787e017: [Java.Base-Tests] Test Java-to-Managed invocations for Java.Base (#975) * dotnet/java-interop@59716252: [build] `main` *conceptually* targets .NET 7 (#978) * dotnet/java-interop@61cdb40d: [generator] Fix reserved keywords binary search (#977)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: dotnet/java-interop@2a882d2...4787e01
mainconceptually targets .NET 7 (Bump to Java.Interop/master/00ad8d6 #978)