[xaprepare] Allow desired Android SDK platform levels to be selected. #6874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
selective-platforms
branch
from
757ad50 to
92d73e6
Compare
jpobst
force-pushed
the
selective-platforms
branch
from
92d73e6 to
1713414
Compare
jpobst
requested review from
grendello,
jonathanpeppers,
jonpryor and
pjcollins
and removed request for
grendello,
jonpryor and
pjcollins
pjcollins
approved these changes
Mar 30, 2022
Member
pjcollins
left a comment
pjcollins
left a comment
There was a problem hiding this comment.
The AndroidToolchainComponentType.BuildDependency flag could also be used here, if it is added to the API levels that aren't required by tests the AndroidTestDependencies scenario would skip them by default. The new argument that lets you select specific versions for any xaprepare scenario also seems like a good addition.
grendello
approved these changes
Mar 30, 2022
jonathanpeppers
approved these changes
Mar 30, 2022
jpobst
added a commit
that referenced
this pull request
Mar 13, 2023
[Previously](#6874), we reduced the number of Android SDK Platforms that needed to be installed on CI test agents to `19,21,26,32,33`. This can significantly reduce the amount of time needed to `xaprepare` an agent. With most uses of Classic gone from `main`, retesting this reveals more platforms that can be removed. Removing `19,21,26,32` saves up to 2 minutes of `xaprepare` time, particularly on Windows. Note: API 27+ should be already installed on our images: - [Mac preinstalled software](https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md#android) - [Windows preinstalled software](https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md#android)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we need all Android SDK platforms to perform the
api-mergeneeded to build Xamarin.Android. However, we do not need all of them on the test agents in order to run our tests.Add an option to
xapreparecalled--android-sdk-platformsthat can be used to specify which API levels are needed.For test agents, request API levels
19,21,26,32needed for tests to successfully run. This cuts the time taken for thexapreparestep on a fresh Windows VM image from19m:36sto5m:11s.A future enhancement would be to examine the tests that require API levels 19/21/26 to determine if these tests actually need to run against those levels, or if they could be updated to use the latest level.
Tests requiring old API levels:
26 - CheckMaxResWarningIsEmittedAsAWarning
21 - FailedBuildFew_ConflictingTextView, FailedBuildMany_ConflictingLinearLayout, SuccessfulBuildFew_DTB, etc.
19 - CheckTargetFrameworkVersion