Skip to content

[MSBuildDeviceIntegration] Add nightly localization unit tests. #6693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 29, 2022
Merged

[MSBuildDeviceIntegration] Add nightly localization unit tests. #6693

merged 20 commits into from
Nov 29, 2022
+358 −10

Conversation

@dellis1972
Copy link
Contributor

@dellis1972 dellis1972 commented Feb 1, 2022

Lets add some unit tests for localization. These need to run on an
emulator like our timezone tests. We should do this on a nightly
test run as they take a long time to run.

@dellis1972
Copy link
Contributor Author

dellis1972 commented Feb 3, 2022

investigating this failure when using he-IL

02-03 11:34:17.824 12325 12325 V mono-stdout: TimeZoneInfoNative=Etc/UTC
02-03 11:34:18.471 12325 12325 V mono-stdout: TimeZoneInfo=Etc/UTC
02-03 11:34:18.471 12325 12325 V mono-stdout: CurrentCulture=
02-03 11:34:18.963 12325 12325 I monodroid-timing: Typemap.managed_to_java: end, total time; elapsed: 0s:0::51000
02-03 11:34:18.964 12325 12325 I monodroid-timing: Runtime.register: registering type `Android.Runtime.JavaProxyThrowable, Mono.Android`
02-03 11:34:18.964 12325 12325 I monodroid-timing: Typemap.managed_to_java: end, total time; elapsed: 0s:0::49000
02-03 11:34:18.964 12325 12325 I monodroid-timing: Runtime.register: end time; elapsed: 0s:0::358000
02-03 11:34:18.994 12325 12325 D AndroidRuntime: Shutting down VM
--------- beginning of crash
02-03 11:34:18.998 12325 12325 E AndroidRuntime: FATAL EXCEPTION: main
02-03 11:34:18.998 12325 12325 E AndroidRuntime: Process: Xamarin.TimeZoneTest, PID: 12325
02-03 11:34:18.998 12325 12325 E AndroidRuntime: android.runtime.JavaProxyThrowable: System.Resources.MissingManifestResourceException: Could not find any resources appropriate for the specified culture or the neutral culture.  Make sure "UnnamedProject.Strings.resources" was correctly embedded or linked into assembly "UnnamedProject" at compile time, or that all the satellite assemblies required are loadable and fully signed.
02-03 11:34:18.998 12325 12325 E AndroidRuntime:   at System.Resources.ManifestBasedResourceGroveler.HandleResourceStreamMissing (System.String fileName) [0x000bc] in <a8b4702b60024176b74a9d7a0c8fe330>:0 
02-03 11:34:18.998 12325 12325 E AndroidRuntime:   at System.Resources.ManifestBasedResourceGroveler.GrovelForResourceSet (System.Globalization.CultureInfo culture, System.Collections.Generic.Dictionary`2[TKey,TValue] localResourceSets, System.Boolean tryParents, System.Boolean createIfNotExists, System.Threading.StackCrawlMark& stackMark) [0x000d9] in <a8b4702b60024176b74a9d7a0c8fe330>:0 
02-03 11:34:18.998 12325 12325 E AndroidRuntime:   at System.Resources.ResourceManager.InternalGetResourceSet (System.Globalization.CultureInfo requestedCulture, System.Boolean createIfNotExists, System.Boolean tryParents, System.Threading.StackCrawlMark& stackMark) [0x00099] in <a8b4702b60024176b74a9d7a0c8fe330>:0 
02-03 11:34:18.998 12325 12325 E AndroidRuntime:   at System.Resources.ResourceManager.InternalGetResourceSet (System.Globalization.CultureInfo culture, System.Boolean createIfNotExists, System.Boolean tryParents) [0x00002] in <a8b4702b60024176b74a9d7a0c8fe330>:0 
02-03 11:34:18.998 12325 12325 E AndroidRuntime:   at System.Resources.ResourceManager.GetString (System.String name, System.Globalization.CultureInfo culture) [0x0005a] in <a8b4702b60024176b74a9d7a0c8fe330>:0 
02-03 11:34:18.998 12325 12325 E AndroidRuntime:   at UnnamedProject.Strings.get_SomeString () [0x00006] in <1e6602b2c4aa49ac8b9607632b45a2a1>:0 
02-03 11:34:18.998 12325 12325 E AndroidRuntime:   at UnnamedProject.MainPage..ctor () [0x0005d] in <1e6602b2c4aa49ac8b9607632b45a2a1>:0 
02-03 11:34:18.998 12325 12325 E AndroidRuntime:   at UnnamedProject.App..ctor () [0x0000f] in <1e6602b2c4aa49ac8b9607632b45a2a1>:0 
02-03 11:34:18.998 12325 12325 E AndroidRuntime:   at UnnamedProject.MainActivity.OnCreate (Android.OS.Bundle savedInstanceState) [0x00027] in <1e6602b2c4aa49ac8b9607632b45a2a1>:0 
02-03 11:34:18.998 12325 12325 E AndroidRuntime:   at Android.App.Activity.n_OnCreate_Landroid_os_Bundle_ (System.IntPtr jnienv, System.IntPtr native__this, System.IntPtr native_savedInstanceState) [0x0000f] in <b56f0bd1dbfd4085933b7de5ba27fa55>:0 
02-03 11:34:18.998 12325 12325 E AndroidRuntime:   at Android.Runtime.JNINativeWrapper+<>c__DisplayClass5_3.<CreateBuiltInDelegate>b__3 (System.IntPtr jnienv, System.IntPtr klazz, System.IntPtr p0) [0x00005] in <b56f0bd1dbfd4085933b7de5ba27fa55>:0

@dellis1972 dellis1972 force-pushed the localizationtests branch 3 times, most recently from 3294606 to 17aaa26 Compare February 11, 2022 10:38
@dellis1972 dellis1972 force-pushed the localizationtests branch 2 times, most recently from 5c02dbc to 4afab48 Compare February 21, 2022 22:07
@dellis1972 dellis1972 force-pushed the localizationtests branch 3 times, most recently from 514fed7 to 46b043d Compare May 9, 2022 10:32
@dellis1972 dellis1972 force-pushed the localizationtests branch from 46b043d to ce08dd2 Compare May 31, 2022 09:32
@dellis1972 dellis1972 force-pushed the localizationtests branch 3 times, most recently from e28c896 to 83cc727 Compare November 8, 2022 14:35
@dellis1972 dellis1972 marked this pull request as ready for review November 15, 2022 16:30
jonathanpeppers
jonathanpeppers approved these changes Nov 15, 2022
View reviewed changes
pjcollins
pjcollins reviewed Nov 15, 2022
View reviewed changes
@dellis1972 dellis1972 force-pushed the localizationtests branch 2 times, most recently from acef3cd to 058d0a5 Compare November 16, 2022 16:03
@dellis1972
[MSBuildDeviceIntegration] Add nightly localization unit tests.
2b97b0b 
Lets add some unit tests for localization. These need to run on an
emulator like our timezone tests. We should do this on a nightly
test run as they take a long time to run.
@dellis1972
Ignore new Localization tests on PR runs
a51aae4
@dellis1972
fix formating issue
0ad7a29
@dellis1972
Fix another typo
c40307f
@dellis1972
Filter out some more tests. Add Logging
d064592
@dellis1972
Run Random tests
eb53c20
@jonpryor
Copy link
Contributor

jonpryor commented Nov 22, 2022

Related: 2012

@jonpryor
Copy link
Contributor

jonpryor commented Nov 22, 2022

WIP commit message:

[tests] Add nightly localization unit tests (#6693)

Add some unit tests for localization.  These need to run on an
emulator like our timezone tests.

Run these tests on a nightly basis as they take a long time to run.

@jonpryor jonpryor merged commit 997c22e into dotnet:main Nov 29, 2022
@dellis1972 dellis1972 deleted the localizationtests branch November 30, 2022 16:05
grendello added a commit to grendello/xamarin-android that referenced this pull request Nov 30, 2022
@grendello
Merge branch 'main' into native-profiling-and-debugging
ae9fe5d 
* main:
  [tests] Add nightly localization unit tests (dotnet#6693)
  [Xamarin.Android.Build.Tasks] Fix XA4215 if AssemblyName is the same (dotnet#7477)
  Bump to dotnet/installer@24f5950 8.0.100-alpha.1.22577.1 (dotnet#7585)
  Bump manifest-merger from 30.3.0 to 30.3.1 in /src/manifestmerger (dotnet#7467)
@jonpryor jonpryor mentioned this pull request Mar 23, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@pjcollins pjcollins pjcollins approved these changes

@jonpryor jonpryor Awaiting requested review from jonpryor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dellis1972 @jonpryor @jonathanpeppers @pjcollins