[ci] Move Linux tests to separate stage #6593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcollins
force-pushed
the
more-linux-tests
branch
3 times, most recently
from
d792d07 to
af31b30
Compare
pjcollins
force-pushed
the
more-linux-tests
branch
7 times, most recently
from
3540f7e to
b712565
Compare
pjcollins
force-pushed
the
more-linux-tests
branch
from
b712565 to
4d76dbf
Compare
pjcollins
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
grendello
approved these changes
Jan 5, 2022
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Should this PR also start pushing the Linux pack to the dotnet6 feed?
If the Smoke Tests are green, it seems good enough to "ship" it?
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Common/TestEnvironment.cs
Outdated
Show resolved
Hide resolved
| TestEnvironment.MonoAndroidToolsDirectory : | ||
| Path.Combine (XABuildPaths.PrefixDirectory, "lib", "xamarin.android", "xbuild", "Xamarin", "Android"); | ||
| string multidex_jar = Path.Combine (multidex_path, "android-support-multidex.jar"); | ||
| string multidex_jar = Path.Combine (bbuilder.AndroidMSBuildDirectory, "android-support-multidex.jar"); |
Member
There was a problem hiding this comment.
This looks fine to me, this test just needs a valid android-support-multidex.jar from somewhere. It doesn't need to be a particular version of it.
Member
Author
|
I've got pjcollins@628c9f8 in the works to follow up with signing/feed pushing after this lands |
…mon/TestEnvironment.cs Co-authored-by: Jonathan Peppers <[email protected]>
jonathanpeppers
approved these changes
Jan 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5701
Adds a Linux test stage to exercise the
Microsoft.Android.Sdk.Linux.nupkg produced by the Linux build. This stage contains one job that
runs the
SmokeTestscategory of our MSBuild tests.A couple of updates have been made to
Xamarin.ProjectToolsto supporttest environments that do not have a system-wide installation of classic
Xamarin.Android. This effort was focused on getting the
SmokeTestscategory to run, however more test harness changes will be needed in
in this area in the future.