[Xamarin.Android.Build.Tasks] Update Property Cache to include $(AndroidCreatePackagePerAbi) #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oidCreatePackagePerAbi) There was an issue where if we change the value of $(AndroidCreatePackagePerAbi) the task _CreateBaseApk was NOT being run if we had a previous build. In addition were were not logging the value of that property in the BuildApk task.
radical
pushed a commit
that referenced
this pull request
May 8, 2018
Commit b58416a broke compilation of `tests/Java.Interop-Tests/Java.Interop-Tests.csproj`: Java.Interop.Tools.JavaCallableWrappers/SupportDeclarations.cs(146,3): error CS1729: The type `Android.Content.ContentProviderAttribute' does not contain a constructor that takes `1' arguments The cause of the breakage is that commit b58416a removed the `ContentProviderAttribute(string[])` constructor, as it isn't entirely relevant within Java.Interop. Fix the compilation error by using the `ContentProviderAttribute` default constructor within `SupportDeclarations.cs`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where if we change the value of $(AndroidCreatePackagePerAbi)
the task _CreateBaseApk was NOT being run if we had a previous
build. In addition were were not logging the value of that property
in the BuildApk task.