Skip to content

Remove dead code #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Remove dead code #6074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 1 addition & 27 deletions src/monodroid/jni/osbridge.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,33 +1010,7 @@ OSBridge::platform_supports_weak_refs (void)
return use_weak_refs;
}

if (androidSystem.monodroid_get_system_property ("persist.sys.dalvik.vm.lib", &value) > 0) {
int art = 0;
if (!strcmp ("libart.so", value))
art = 1;
free (value);
if (art) {
int use_java = 0;
if (androidSystem.monodroid_get_system_property ("ro.build.version.release", &value) > 0) {
// Android 4.x ART is busted; see https://code.google.com/p/android/issues/detail?id=63929
if (value [0] != 0 && value [0] == '4' && value [1] != 0 && value [1] == '.') {
use_java = 1;
}
free (value);
}
if (use_java) {
log_warn (LOG_GC, "JNI weak global refs are broken on Android with the ART runtime.");
log_warn (LOG_GC, "Trying to use java.lang.WeakReference instead, but this may fail as well.");
log_warn (LOG_GC, "App stability may be compromised.");
log_warn (LOG_GC, "See: https://code.google.com/p/android/issues/detail?id=63929");
return 0;
}
}
}

if (api_level > 7)
return 1;
return 0;
return 1;
}

void
Expand Down