Bump to xamarin/monodroid/main@1f2ce156 #5991
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Maybe don't merge this one yet, I found an issue testing this: I added a line like this to my But I didn't get the change. |
jonathanpeppers
force-pushed
the
monodroid-65b7b2dd
branch
from
cb62245 to
1e054d8
Compare
jonathanpeppers
changed the title
Member
Author
|
The issue in #5991 (comment) should be working now. I believe I was only seeing the problem in an earlier incarnation of https://github.com/xamarin/monodroid/pull/1205. |
Member
Author
|
Latest issue here, is we should only be doing this block when Fast Deployment is enabled... |
Changes: xamarin/monodroid@76c04cd...1f2ce15 * [tools/msbuild] Missing translations for XA0135 * Bump to dotnet/android@032d840, xamarin/androidtools@355d015 * [build] fix dotnet tool install command * [tools/fastdev] Rework Unix timestamp calculation code in xamarin.find * [tools/fastdev] Add error checking when writing data to disk. * [tools/msbuild] <GetPrimaryCpuAbi/> selects backup RIDs for .NET 6 * Bump android-sdk-installer to use Mono.Unix * [tools/msbuild] only run _GetPrimaryCpuAbi for Fast Dev Other changes: * `InstantRunNativeLibrary` will need to set the ABI in the `.csproj` in order for the test to pass on .NET 6. It's use of `BaseTest.DeviceAbi` would not match for an x86_64 emulator.
jonathanpeppers
force-pushed
the
monodroid-65b7b2dd
branch
from
eefb249 to
8f0da7c
Compare
jonathanpeppers
changed the title
Member
Author
|
Closing in favor of: #5971 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: https://github.com/xamarin/monodroid/compare/76c04cd1...1f2ce156
Other changes:
InstantRunNativeLibrarywill need to set the ABI in the.csprojin order for the test to pass on .NET 6. It's use of
BaseTest.DeviceAbiwould not match for an x86_64 emulator.