[Xamarin.Android.Build.Tests] Fix some of the dropbox links and the location of android-support-multidex.jar #562
Conversation
| binding.AndroidClassParser = "class-parse"; | ||
| binding.Jars.Add (new AndroidItem.EmbeddedJar (() => "$(MonoDroidInstallDirectory)\\lib\\mandroid\\android-support-multidex.jar")); | ||
| var multidexJar = Environment.OSVersion.Platform == PlatformID.Win32NT | ||
| ? Path.Combine (Environment.GetFolderPath (Environment.SpecialFolder.ProgramFilesX86), "MSBuild", "Xamarin", "Android", "android-support-multidex.jar") |
There was a problem hiding this comment.
I'd rather not hardcode %ProgramFiles(x86)%\..., because eventually we'll want to be able to build and run unit tests on Windows, and that environment will not be in %ProgramFiles(x86)%...
Perhaps we should go with this for now, and then fix it when we address PR #253?
There was a problem hiding this comment.
Outside of VS2017 (VS2015 etc) it is in Program Files (x86)..
Not sure how we run the tests under VS2017 because the locations depend on the version you run. Which sucks in my opinion.
There was a problem hiding this comment.
The "proper" mechanism is to use the XAMARIN_ANDROID_REGKEY environment variable. This is how Visual Studio communicates to our build system where things are located...ish.
| binding.Jars.Add (new AndroidItem.EmbeddedJar (() => "$(MonoDroidInstallDirectory)\\lib\\mandroid\\android-support-multidex.jar")); | ||
| var multidexJar = Environment.OSVersion.Platform == PlatformID.Win32NT | ||
| ? Path.Combine (Environment.GetFolderPath (Environment.SpecialFolder.ProgramFilesX86), "MSBuild", "Xamarin", "Android", "android-support-multidex.jar") | ||
| : "$(MonoDroidInstallDirectory)\\lib\\mandroid\\android-support-multidex.jar"; |
There was a problem hiding this comment.
Why not Path.Combine() here as well? Or at least use @"..." strings?
dellis1972
changed the title
…ocation of android-support-multidex.jar Dropbox recently invalidated ALL shared folders/links. So we need to use new links. Also on windows android-support-multidex.jar in not in lib/mandroid... lib/mandroid does NOT exist. So we need to add a path so we pick that up from the right location.
3 participants
Dropbox recently invalidated ALL shared folders/links.
So we need to use new links.
Also on windows android-support-multidex.jar in not in
lib/mandroid... lib/mandroid does NOT exist. So we need
to add a path so we pick that up from the right location.