[Xamarin.ProjectTools] fix toggling XamarinProject.IsRelease #5571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4422361&view=ms.vss-test-web.build-test-results-tab&runId=18547936&resultId=100086&paneView=debug We had an MSBuild test failing under .NET 6: MSBuildDeviceIntegration On Device - macOS - One .NET > SwitchConfigurationsShouldRedeploy fastdev directory should NOT exist for Release builds. Expected string length 0 but was 4970. Strings differ at index 0. Expected: <string.Empty> But was: "Java.Interop.dll\nMicrosoft.CSharp.dll\nMicrosoft.VisualBasic.C..." This was because a supposed `Release` build was skipping the `_Upload` target completely: Skipping target "_Upload" because all output files are up-to-date with respect to the input files. Input files: bin\Debug\UnnamedProject.UnnamedProject-Signed.apk... It appears that toggling `XamarinProject.IsRelease` is not triggering the correct files to save when the tests run under .NET 6. Under "legacy" Xamarin.Android, the tests simply put this at the top of the `.csproj`: <Configuration>Debug</Configuration> ... <Import Project="$(MSBuildExtensionsPath)\Xamarin\Android\Xamarin.Android.CSharp.targets" /> This won't work in short-form MSBuild projects, because the `.csproj` is effectively: <Import Sdk="Microsoft.NET.Sdk" Project="Sdk.props" /> ... <Configuration>Debug</Configuration> ... <Import Sdk="Microsoft.NET.Sdk" Project="Sdk.targets" /> For things to work properly, we need `$(Configuration)` to be set *before* `Microsoft.NET.Sdk/Sdk.props`. So we put `$(Configuration)` in a `Directory.Build.props` to solve this ordering problem. Unfortunately, we were not calling `Touch()` on this file when `XamarinProject.IsRelease` changes. After making this change, `SwitchConfigurationsShouldRedeploy` passes.
dellis1972
approved these changes
Feb 1, 2021
Contributor
|
Failing test is The logcat This fails on both Legacy and One. net. So I assume its not related. So I will merge this one |
Contributor
|
To keep the link here for future reference. This may help in debugging dlopen behavior on Android O and newer: https://android.googlesource.com/platform/bionic/+/master/android-changes-for-ndk-developers.md#enable-logging-of-dlopen_dlsym-and-library-loading-errors-for-apps-available-in-android-o |
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Mar 30, 2021
…5571) Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4422361&view=ms.vss-test-web.build-test-results-tab&runId=18547936&resultId=100086&paneView=debug We had an MSBuild test failing under .NET 6: MSBuildDeviceIntegration On Device - macOS - One .NET > SwitchConfigurationsShouldRedeploy fastdev directory should NOT exist for Release builds. Expected string length 0 but was 4970. Strings differ at index 0. Expected: <string.Empty> But was: "Java.Interop.dll\nMicrosoft.CSharp.dll\nMicrosoft.VisualBasic.C..." This was because a supposed `Release` build was skipping the `_Upload` target completely: Skipping target "_Upload" because all output files are up-to-date with respect to the input files. Input files: bin\Debug\UnnamedProject.UnnamedProject-Signed.apk... It appears that toggling `XamarinProject.IsRelease` is not triggering the correct files to save when the tests run under .NET 6. Under "legacy" Xamarin.Android, the tests simply put this at the top of the `.csproj`: <Configuration>Debug</Configuration> ... <Import Project="$(MSBuildExtensionsPath)\Xamarin\Android\Xamarin.Android.CSharp.targets" /> This won't work in short-form MSBuild projects, because the `.csproj` is effectively: <Import Sdk="Microsoft.NET.Sdk" Project="Sdk.props" /> ... <Configuration>Debug</Configuration> ... <Import Sdk="Microsoft.NET.Sdk" Project="Sdk.targets" /> For things to work properly, we need `$(Configuration)` to be set *before* `Microsoft.NET.Sdk/Sdk.props`. So we put `$(Configuration)` in a `Directory.Build.props` to solve this ordering problem. Unfortunately, we were not calling `Touch()` on this file when `XamarinProject.IsRelease` changes. After making this change, `SwitchConfigurationsShouldRedeploy` passes.
jonpryor
pushed a commit
that referenced
this pull request
Mar 30, 2021
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4422361&view=ms.vss-test-web.build-test-results-tab&runId=18547936&resultId=100086&paneView=debug We had an MSBuild test failing under .NET 6: MSBuildDeviceIntegration On Device - macOS - One .NET > SwitchConfigurationsShouldRedeploy fastdev directory should NOT exist for Release builds. Expected string length 0 but was 4970. Strings differ at index 0. Expected: <string.Empty> But was: "Java.Interop.dll\nMicrosoft.CSharp.dll\nMicrosoft.VisualBasic.C..." This was because a supposed `Release` build was skipping the `_Upload` target completely: Skipping target "_Upload" because all output files are up-to-date with respect to the input files. Input files: bin\Debug\UnnamedProject.UnnamedProject-Signed.apk... It appears that toggling `XamarinProject.IsRelease` is not triggering the correct files to save when the tests run under .NET 6. Under "legacy" Xamarin.Android, the tests simply put this at the top of the `.csproj`: <Configuration>Debug</Configuration> ... <Import Project="$(MSBuildExtensionsPath)\Xamarin\Android\Xamarin.Android.CSharp.targets" /> This won't work in short-form MSBuild projects, because the `.csproj` is effectively: <Import Sdk="Microsoft.NET.Sdk" Project="Sdk.props" /> ... <Configuration>Debug</Configuration> ... <Import Sdk="Microsoft.NET.Sdk" Project="Sdk.targets" /> For things to work properly, we need `$(Configuration)` to be set *before* `Microsoft.NET.Sdk/Sdk.props`. So we put `$(Configuration)` in a `Directory.Build.props` to solve this ordering problem. Unfortunately, we were not calling `Touch()` on this file when `XamarinProject.IsRelease` changes. After making this change, `SwitchConfigurationsShouldRedeploy` passes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4422361&view=ms.vss-test-web.build-test-results-tab&runId=18547936&resultId=100086&paneView=debug
We had an MSBuild test failing under .NET 6:
This was because a supposed
Releasebuild was skipping the_Uploadtarget completely:
It appears that toggling
XamarinProject.IsReleaseis not triggeringthe correct files to save when the tests run under .NET 6.
Under "legacy" Xamarin.Android, the tests simply put this at the top
of the
.csproj:This won't work in short-form MSBuild projects, because the
.csprojis effectively:
For things to work properly, we need
$(Configuration)to be setbefore
Microsoft.NET.Sdk/Sdk.props.So we put
$(Configuration)in aDirectory.Build.propsto solvethis ordering problem. Unfortunately, we were not calling
Touch()onthis file when
XamarinProject.IsReleasechanges.After making this change,
SwitchConfigurationsShouldRedeploypasses.