[Xamarin.Android.Build.Tasks] Use Microsoft.Android.Build.BaseTasks #5464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcollins
force-pushed
the
shared-mabt
branch
2 times, most recently
from
194a7c4 to
cdd19ec
Compare
We would like to eventually remove the dependency that xamarin/monodroid has on xamarin/xamarin-android. As a first step towards this effort, shared MSBuild code is being moved to xamarin/xamarin-android-tools. Xamarin.Android.Build.Tasks has been updated to use the new shared Microsoft.Android.Build.Tasks sources. The inverted monodroid build has been replaced with the new monodroid build system. The one test remaining in monodroid has been moved into the DebuggingTasksTests file which is conditionally compiled. Relevant tests have been moved into xamarin/xamarin-android-tools to a new `Microsoft.Android.Build.BaseTasks-Tests` assembly.
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Otherwise, I looked through the diff. Looks good so far. 👍
dellis1972
reviewed
Feb 3, 2021
pjcollins
changed the title
dellis1972
approved these changes
Feb 4, 2021
jonathanpeppers
approved these changes
Feb 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android-tools#101
Context: https://github.com/xamarin/monodroid/pull/1145
We would like to eventually remove the dependency that xamarin/monodroid
has on xamarin/xamarin-android. As a first step towards this effort,
shared MSBuild code is being moved to xamarin/xamarin-android-tools.
Xamarin.Android.Build.Taskshas been updated to use the new sharedMicrosoft.Android.Build.BaseTaskssources. All of the files that weremoved to xamarin/xamarin-android-tools have been deleted.
The inverted monodroid build has been replaced with the new monodroid
build system, see https://github.com/xamarin/monodroid/pull/1145 for
more context. The one build task test that was still being ran from the
xamarin/monodroid repo has been moved into
DebuggingTasksTests.cs,which is conditionally included in
Xamarin.Android.Build.Tests.Tests associated with the build task source that was moved to
xamarin/xamarin-android-tools have also been moved to a new
Microsoft.Android.Build.BaseTasks-Testsassembly in that repo.