Bump to Java.Interop/master/5eeb287b #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commits prior to Java.Interop/5eeb287b had a bug in `Xamarin.Android.Cecil.csproj` which would cause it to constantly generate new assemblies whenever it was built. The result being that: xbuild src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj would *always* take a lengthy amount of time -- ~36 seconds -- even when "nothing has changed." In fact, something *had* changed: `Xamarin.Android.Cecil.dll` had changed, necessitating that *every project that references it* also be rebuilt, in a cascading manner: Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Xamarin.Android.Cecil.dll' is newer than output file 'obj/Debug/Xamarin.Android.Tools.Aidl.dll' Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Xamarin.Android.Cecil.dll' is newer than output file 'obj/Debug/Java.Interop.Tools.Diagnostics.dll' Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Java.Interop.Tools.Diagnostics.dll' is newer than output file 'obj/Debug/Java.Interop.Tools.Cecil.dll' Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Java.Interop.Tools.Cecil.dll' is newer than output file 'obj/Debug/Java.Interop.Tools.JavaCallableWrappers.dll' Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Xamarin.Android.Cecil.dll' is newer than output file 'obj/Debug/generator.exe' Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Xamarin.Android.Cecil.dll' is newer than output file 'obj/Debug/jcw-gen.exe' Target CoreCompile needs to be built as input file '.../xamarin-android/external/Java.Interop/bin/Debug//Xamarin.Android.Cecil.dll' is newer than output file 'obj/Debug/remap-assembly-ref.exe' Target _BuildJNIEnv needs to be built as input file '../../bin/BuildDebug/jnienv-gen.exe' is newer than output file 'Android.Runtime/JNIEnv.g.cs' Target _GenerateMonoAndroidDex18 needs to be built as input file '../../bin/Debug/lib/xbuild-frameworks/MonoAndroid/v7.1/mono.android.jar' is newer than output file '../../bin/Debug/lib/xbuild-frameworks/MonoAndroid/v7.1/mono.android.dex' Target CoreCompile needs to be built as input file 'obj/Debug/Profile.g.cs' is newer than output file 'obj/Debug/Xamarin.Android.Build.Tasks.dll' This is maddening, and serves no purpose. Java.Interop/5eeb287b fixed `Xamarin.Android.Cecil.csproj` so that it wouldn't constantly regenerate the output assembly, which should help improve the cascading rebuild situation.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Dec 19, 2019
Changes: dotnet/java-interop@f3553f4...d61b329 * dotnet/java-interop@d61b329 [Java.Interop-Tests] Relax Exception.Message checks (dotnet#544) * dotnet/java-interop@d778204 [Java.Interop] Better linker-friendly JavaObjectArray<T>.ValueMarshaler (dotnet#546) * dotnet/java-interop@4bd07e0 [vs-code] Recommend the zbecknell.t4-support extension (dotnet#545) * dotnet/java-interop@3b24a2c [Java.Interop] apply AggressiveInlining where profiler shows calls (dotnet#541)
jonpryor
added a commit
that referenced
this pull request
Dec 20, 2019
Changes: dotnet/java-interop@f3553f4...d61b329 * dotnet/java-interop@d61b329 [Java.Interop-Tests] Relax Exception.Message checks (#544) * dotnet/java-interop@d778204 [Java.Interop] Better linker-friendly JavaObjectArray<T>.ValueMarshaler (#546) * dotnet/java-interop@4bd07e0 [vs-code] Recommend the zbecknell.t4-support extension (#545) * dotnet/java-interop@3b24a2c [Java.Interop] apply AggressiveInlining where profiler shows calls (#541)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits prior to Java.Interop/5eeb287b had a bug in
Xamarin.Android.Cecil.csprojwhich would cause it to constantlygenerate new assemblies whenever it was built.
The result being that:
would always take a lengthy amount of time -- ~36 seconds -- even
when "nothing has changed." In fact, something had changed:
Xamarin.Android.Cecil.dllhad changed, necessitating thatevery project that references it also be rebuilt, in a cascading
manner:
This is maddening, and serves no purpose.
Java.Interop/5eeb287b fixed
Xamarin.Android.Cecil.csprojso that itwouldn't constantly regenerate the output assembly, which should help
improve the cascading rebuild situation.