Build with net5.0 TFM instead of netcoreapp3.1 #5282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That would allow use of new NET5 API like the new dynamic dependency [attribute](https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.dynamicdependencyattribute?view=net-5.0). Also replace NET5_LINKER define with NET5_0. Context: dotnet/sdk#13615
Member
Author
|
This PR is draft as it needs newer msbuild 16.8, which will be available in the next VS 2019 release. It also needs dotnet/java-interop#747 |
Member
|
I think we can close this now that #5891 has been merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build with net5.0 TFM instead of netcoreapp3.1
That would allow use of new NET5 API like the new dynamic dependency
attribute.
Also replace NET5_LINKER define with NET5_0.