[Xamarin.Android.Build.Tasks] do not require JDK 11 for build-tools 30 #5231
Conversation
|
Everything looks good, though do wonder about the Designer integration test failure. "Random", or did we break something, or is it an "upstream" bug? I've restarted those tests, so we can possibly eliminate "random"… |
|
When I click on the first instance of the designer test failing, it seems like it happened on one of Radek's PRs that isn't merged. I think they probably have a test failing on xamarin/uitools/master.
|
|
Since #5234 came in, let me add a release note for it. |
Fixes: dotnet#5234 I was building a project and hit: ``` error XA0032: Java SDK 11.0 or above is required when using Android SDK Build-Tools 30.0.2. ``` This is actually not true anymore since we got c50df1c and other changes in to redistribute `apksigner.jar`. Let's drop this check, and just require JDK 1.8.
jonathanpeppers
force-pushed
the
build-tools-30-jdk-11
branch
from
9db57d8 to
753eb56
Compare
| if (!Version.TryParse (buildToolsVersionString, out buildTools)) { | ||
| return Version.Parse (LatestSupportedJavaVersion); | ||
| } | ||
| if (buildTools >= new Version (30, 0, 0)) |
There was a problem hiding this comment.
It occurs to me that instead of removing this check entirely, we should instead be "more accurate". We know Build-tools 30.0.0 and 30.0.1 require JDK 11, it's 30.0.2 (and later?) that work with JDK 8. Thus, should we check for what we know?
if (buildTools >= new Version (30, 0, 0) && buildTools < new Version (30, 0 2)) {
return new Version (11, 0);
}There was a problem hiding this comment.
Since we redistribute apksigner.jar now, both 30.0.0 and 30.0.1 will work.
4 participants
Fixes: #5234
I was building a project and hit:
This is actually not true anymore since we got c50df1c and other
changes in to redistribute
apksigner.jar. Let's drop this check, andjust require JDK 1.8.
I'm not actually sure how others haven't run into this?