[Xamarin.Android.Build.Tests] Import regression tests from job 1 #5030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also escape the destination path and don't attach the log twice
dellis1972
approved these changes
Aug 20, 2020
Member
Author
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/DeviceTest.cs
Show resolved
Hide resolved
jonathanpeppers
approved these changes
Aug 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/xamarin/QualityAssurance/pull/3639
This is an initial effort to migrate non duplicated and relevant tests
from QualityAssurance into xamarin-android. The majority of test
categories that ran in the first regression test job have been audited,
and a few tests have been imported while the rest have been removed.
The remaining regression test categories that were ran as part of the
first and second regression test jobs have been merged, and the third
job has been removed.
Device tests that searched for
.__override__directory content aftera Release build have been updated to have a stricter assert.
These tests will also now set
android:debuggable="true"to allowusage of the run-as command, which is required when attempting
to list the content of the potential
/data/data/*location.The DeviceTest base class has been updated to ensure logcat output
is captured on failure by escaping the destination path, and a duplicate
AddTestAttachmentcall has been removed.