[ci] Install JetBrains OpenJDK 8, 11 #4773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
approved these changes
Jun 5, 2020
Context: dotnet#4567 We want to support using OpenJDK 11 to build Xamarin.Android projects. For better or worse, we can't "change the entire world," not all at once. In particular, the Android Designer Integration Tests do not currently support building with or running under JDK 11. "Split the difference", kind of: Instead of installing Corretto JDK 8 into `$HOME/android-toolchain/jdk`, install JetBrains OpenJDK 8 and 11 into the new paths: * `$HOME/android-toolchain/jdk-1.8` * `$HOME/android-toolchain/jdk-11` We will continue *using* JDK 1.8 by default, until PR dotnet#4567 is ready to completely merge, at which point we'll use JDK 11 to build Xamarin.Android, while continuing to use JDK 1.8 with the Designer.
pjcollins
approved these changes
Jun 5, 2020
jonpryor
added a commit
that referenced
this pull request
Jun 8, 2020
Context: #4567 We want to support using OpenJDK 11 to build Xamarin.Android projects. For better or worse, we can't "change the entire world," not all at once. In particular, the Android Designer Integration Tests do not currently support building with or running under JDK 11. "Split the difference", kind of: Instead of installing Corretto JDK 8 into `$HOME/android-toolchain/jdk`, install JetBrains OpenJDK 8 and 11 into the new paths: * `$HOME/android-toolchain/jdk-1.8` * `$HOME/android-toolchain/jdk-11` We will continue *using* JDK 1.8 by default, until PR #4567 is ready to completely merge, at which point we'll use JDK 11 to build Xamarin.Android, while continuing to use JDK 1.8 with the Designer. Co-authored-by: Marek Habersack <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #4567
We want to support using OpenJDK 11 to build Xamarin.Android projects.
For better or worse, we can't "change the entire world," not all at
once. In particular, the Android Designer Integration Tests do not
currently support building with or running under JDK 11.
"Split the difference", kind of: Instead of installing Corretto JDK 8
into
$HOME/android-toolchain/jdk, install JetBrains OpenJDK 8 and 11into the new paths:
$HOME/android-toolchain/jdk-1.8$HOME/android-toolchain/jdk-11We will continue using JDK 1.8 by default, until PR #4567 is ready
to completely merge, at which point we'll use JDK 11 to build
Xamarin.Android, while continuing to use JDK 1.8 with the Designer.