[Mono.Android.dll] Convert map.csv to v2 format. #4665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
new-enum-parse
branch
2 times, most recently
from
561e344 to
f5dc30f
Compare
jpobst
changed the title
jonpryor
pushed a commit
that referenced
this pull request
May 26, 2020
Context: dotnet/java-interop@b00e644 Changes: dotnet/java-interop@d6024f1...76d1ac7 * dotnet/java-interop@76d1ac7: [Java.Interop.Tools.Generator] Create a v2 version of map.csv (#646) * dotnet/java-interop@b6c15399: [XAT.Bytecode] Bind Kotlin internal interfaces as package-private (#645) In dotnet/java-interop@b00e644e, we added support for a "v2" version of the `map.csv` file format used to bundle Java constant fields into enumerations. Convert `src/Mono.Android/map.csv` to use this new format to make enumification easier going forward. This does not add any new enumifications. Additionally, the new enum code standardizes on using `$` to denote nested classes, e.g. `java/lang/Thread$State`, not `java/lang/Thread.State`. `$` is correct JNI syntax or nested types. ~Half of this existing file used `$` and half used `.`. This resulted in needing `acceptable-breakage` fixes as this signature changed in the `[IntDefinition]` attribute.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dotnet/java-interop#646, we added a "v2" version of the
map.csvfile format used to bundle Java constant fields into enumerations.This PR converts
Mono.Android.dll's enum map to this new version to make enumification easier going forward. It does not add any new enumifications.Additionally the new enum code standardizes on using
$to denote nested classes. ~Half of this existing file used$and half used.. This resulted in needingacceptable-breakagefixes as this signature changed in the[IntDefinition]attribute.