[XA.Build.Tasks] Use 'android-R' instead of 'android-30' to properly find preview bindings. #4651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…find preview bindings.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonathanpeppers
approved these changes
May 19, 2020
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
The .NET 5 test failures should be fixed by: #4692
jonpryor
pushed a commit
that referenced
this pull request
May 26, 2020
Context: a348617 In order to build preview bindings on Windows, we set the following properties in `Configuration.props`: <AndroidLatestStableApiLevel Condition="'$(AndroidLatestStableApiLevel)' == ''">30</AndroidLatestStableApiLevel> <AndroidLatestStablePlatformId Condition="'$(AndroidLatestStablePlatformId)' == ''">R</AndroidLatestStablePlatformId> <AndroidLatestStableFrameworkVersion Condition="'$(AndroidLatestStableFrameworkVersion)'==''">v10.0.99</AndroidLatestStableFrameworkVersion> This writes the generated files to `src\Mono.Android\obj\$(Configuration)\monoandroid10\android-R\mcw`. However `Xamarin.Android.Build.Tasks.csproj` is looking for files in `src\Mono.Android\obj\$(Configuration)\monoandroid10\android-30\mcw`, because it is using `$(AndroidLatestStableApiLevel)` instead of `$(AndroidLatestStablePlatformId)`. Update `Xamarin.Android.Build.Tasks.csproj` to use `$(AndroidLatestStablePlatformId)`, which allows `msbuild Xamarin.Android.sln` to succeed on Windows when using building for 30/R/v10.0.99.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #4356
In order to build preview bindings on Windows, we set the following properties in
Configuration.props:This writes the generated files to
src\Mono.Android\obj\$(Configuration)\monoandroid10\android-R\mcw, howeverXamarin.Android.Build.Tasks.csprojis looking insrc\Mono.Android\obj\$(Configuration)\monoandroid10\android-30\mcw, because it is using$(AndroidLatestStableApiLevel)instead of$(AndroidLatestStablePlatformId). Fixing this allowsmsbuild Xamarin.Android.slnto succeed on Windows.