[build] Use API-21 for all native builds #4584

grendello · 2020-04-20T17:27:23Z

Up until this commit, we have been building the 64-bit targets (x86-64
and armv8-a against NDK API 21 while the 32-bit targets (x86 and
armv7-a) against NDK API 16. This commit changes it so that all
targets build against API 21. This gives us the ability to speed up
Debug builds on 32-bit platforms via use of POSIX APIs for directory
traversal that are available starting from API 21 onwards (openat and
fstatat). The switch to API 21 was initially planned for .NET5 but
there's no harm in making the change now.

In addition, this commit updates versions of several components:

Bump emulator version to 30.0.5
Bump NDK version to 21b (21.1.6352462)
Bump x86 system image revision to 7

Also, XABuildConfig.NDKMinimumApiAvailable is now set to the minimum
supported NDK API level instead of the minimum API level installed by
the NDK.

brendanzagaeski · 2020-04-21T06:52:48Z

Questions (based on previous similar change in Xamarin.Android 9.3)

Will the changes in this PR also automatically update the warning message for XA4216? It looks like an equivalent question is: Will the changes automatically update the NDKMinimumApiAvailable output from Xamarin.Android.BuildTools.PrepTasks.NDKInfo?

Draft release note

Here's a candidate release note for this change based on the release note for a previous update of the minimum compatible API level. Feel free to suggest changes or even a whole new wording.

### Minimum compatible Android version now Android 5.0 Lollipop (API level 21)

The minimum compatible Android version for Xamarin.Android apps is now Android
5.0 Lollipop (API level 21).  Warning XA4216 has been updated to help highlight
this change for any projects that might still have an older version set for the
`minSdkVersion` in the `AndroidManifest.xml` file:

```
warning XA4216: AndroidManifest.xml //uses-sdk/@android:minSdkVersion '20' is less than API-21, this configuration is not supported.
```

#### Background information

The unmanaged native libraries that are part of Xamarin.Android are now built to
target Android 5.0 Lollipop (API level 21), so apps built using this release can
abort due to incompatible APIs if run on earlier Android versions.

grendello · 2020-04-21T07:42:27Z

Questions (based on previous similar change in Xamarin.Android 9.3)

Will the changes in this PR also automatically update the warning message for XA4216? It looks like an equivalent question is: Will the changes automatically update the NDKMinimumApiAvailable output from Xamarin.Android.BuildTools.PrepTasks.NDKInfo?

The warning message will be updated automatically, yes - it uses a file generated by xaprepare which stores the minimum values. This PR is irrelevant for NKInfo which gathers information about the installed NDK - i.e. what's available on the system.

brendanzagaeski

I tried out the .vsix from this PR. It looks like the XA4216 build warning does not yet appear for android:minSdkVersion below 21 with that .vsix.

Maybe it would be OK to change the way NDKMinimumApiAvailable is defined to match the values from NdkMinimumAPI? At the moment, NDKMinimumApiAvailable is still 16:

ildasm /ITEM=Xamarin.Android.Tools.XABuildConfig::NDKMinimumApiAvailable Xamarin.Android.Build.Tasks.dll

shows:

.field public static literal int32 NDKMinimumApiAvailable = int32(0x00000010)

jonpryor · 2020-04-24T17:36:23Z

build-tools/xaprepare/xaprepare/ConfigAndData/Dependencies/AndroidToolchain.cs

-				new AndroidPlatformComponent ("platform-R_r02",    apiLevel: "R",  pkgRevision: "2"),
+				new AndroidPlatformComponent ("platform-28_r06",   apiLevel: "28", pkgRevision: "6"),
+				new AndroidPlatformComponent ("platform-29_r04",   apiLevel: "29", pkgRevision: "4"),
+				new AndroidPlatformComponent ("platform-R_r03",    apiLevel: "R",  pkgRevision: "3"),


Let's not update API-R to Developer Preview 3, please. This should be done separately, as there's no guarantee that it's API compatible with DP2.

grendello · 2020-04-27T19:46:59Z

/azp run

azure-pipelines · 2020-04-27T19:47:20Z

Azure Pipelines successfully started running 1 pipeline(s).

brendanzagaeski

Approved for both the release note and the updated behavior of the XA4216 warning. Thanks!

I checked the latest .vsix from this PR and verified that NDKMinimumApiAvailable is now 21 and that the XA4216 warning now appears as expected when android:minSdkVersion is less than 21. Looks good.

Up until this commit, we have been building the 64-bit targets (`x86-64` and `armv8-a` against NDK API 21 while the 32-bit targets (`x86` and `armv7-a`) against NDK API 16. This commit changes it so that all targets build against API 21. This gives us the ability to speed up Debug builds on 32-bit platforms via use of POSIX APIs for directory traversal that are available starting from API 21 onwards (`openat` and `fstatat`). The switch to API 21 was initially planned for .NET5 but there's no harm in making the change now. In addition, this commit updates versions of several components: * Bump emulator version to 30.0.5 * Bump NDK version to 21b (21.1.6352462) * Bump x86 system image revision to 7 Also, `XABuildConfig.NDKMinimumApiAvailable` is now set to the minimum supported NDK API level instead of the minimum API level *installed* by the NDK.

Previously, we built the 64-bit targets (`x86-64` and `arm64-v8a`) against NDK API-21 and the32-bit targets (`x86` and `armeabi-v7a`) against NDK API-16. Update so that all targets build against API-21. This gives us the ability to speed up on-device app startup of Debug- configuration builds on 32-bit platforms by using POSIX APIs for directory traversal that are available starting from API-21 onwards ([**openat**(2)][0] and [**fstatat**(2)][1]). The switch to API-21 was initially planned for .NET5 but there's no significant harm in making the change now. In addition, this commit updates versions of several components: * Bump emulator version to 30.0.5 * Bump NDK version to 21b (21.1.6352462) * Bump x86 system image revision to 7 Also, `XABuildConfig.NDKMinimumApiAvailable` is now set to the minimum supported NDK API level instead of the minimum API level *installed* by the NDK. TODO: This commit knowingly breaks some unit tests, e.g. `Xamarin.Android.Build.Tests.BuildTest.BuildMultiDexApplication()`. These will be fixed in a later commit. [0]: https://linux.die.net/man/2/openat [1]: https://linux.die.net/man/2/fstatat

This reverts commit f852c60.

This reverts commit a648981.

Context: https://docs.microsoft.com/en-us/xamarin/get-started/supported-platforms?tabs=windows Context: https://github.com/dotnet/maui#xamarinforms-vs-net-maui This reverts commit a648981. Xamarin.Forms advertises a supported minimum API level of API-19, which commit a648981 removed support for. This change complicates the life of the Xamarin.Forms team. We will eventually drop support for API-19 -- certainly as part of .NET 5/6 -- but for now preserve API-19 compatibility.

grendello requested a review from jonpryor as a code owner April 20, 2020 17:27

grendello force-pushed the api21-for-all branch from ffbd77a to 182f2c2 Compare April 20, 2020 18:31

grendello requested review from dellis1972 and jonathanpeppers as code owners April 20, 2020 18:31

jonathanpeppers approved these changes Apr 20, 2020

View reviewed changes

grendello force-pushed the api21-for-all branch from 182f2c2 to 345738e Compare April 21, 2020 07:46

grendello requested a review from brendanzagaeski as a code owner April 21, 2020 07:46

grendello force-pushed the api21-for-all branch from 345738e to b3fb3b3 Compare April 21, 2020 08:17

dellis1972 approved these changes Apr 21, 2020

View reviewed changes

brendanzagaeski suggested changes Apr 21, 2020

View reviewed changes

grendello force-pushed the api21-for-all branch from b3fb3b3 to 8799bf8 Compare April 24, 2020 11:16

grendello requested a review from brendanzagaeski April 24, 2020 11:17

grendello force-pushed the api21-for-all branch from 8799bf8 to 43c8541 Compare April 24, 2020 17:27

jonpryor reviewed Apr 24, 2020

View reviewed changes

grendello force-pushed the api21-for-all branch 7 times, most recently from ab1aa68 to 166604c Compare April 27, 2020 10:24

dellis1972 approved these changes Apr 27, 2020

View reviewed changes

grendello force-pushed the api21-for-all branch from 312d272 to 9187019 Compare April 27, 2020 18:51

grendello force-pushed the api21-for-all branch 3 times, most recently from d84a7b0 to 97b5183 Compare April 28, 2020 19:13

grendello force-pushed the api21-for-all branch 5 times, most recently from 168e467 to e3ce249 Compare April 29, 2020 20:41

brendanzagaeski approved these changes Apr 30, 2020

View reviewed changes

grendello force-pushed the api21-for-all branch from e3ce249 to e3e2d6c Compare April 30, 2020 08:00

jonpryor merged commit a648981 into dotnet:master Apr 30, 2020

grendello deleted the api21-for-all branch April 30, 2020 18:13

brendanzagaeski added this to the In Preview: 10.4 (d16-7) milestone Jun 3, 2020

grendello added a commit to grendello/xamarin-android that referenced this pull request Jun 5, 2020

Revert "[build] Use API-21 for all native builds (dotnet#4584)"

651209e

This reverts commit f852c60.

grendello added a commit to grendello/xamarin-android that referenced this pull request Jun 5, 2020

Revert "[build] Use API-21 for all native builds (dotnet#4584)"

87c28c3

This reverts commit a648981.

brendanzagaeski removed this from the In Preview: 10.4 (d16-7) milestone Jun 23, 2020

github-actions bot locked and limited conversation to collaborators Jan 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[build] Use API-21 for all native builds #4584

[build] Use API-21 for all native builds #4584

Uh oh!

grendello commented Apr 20, 2020 •

edited

Loading

Uh oh!

brendanzagaeski commented Apr 21, 2020

Uh oh!

grendello commented Apr 21, 2020

Uh oh!

brendanzagaeski left a comment

Uh oh!

jonpryor Apr 24, 2020

Uh oh!

grendello commented Apr 27, 2020

Uh oh!

azure-pipelines bot commented Apr 27, 2020

Uh oh!

brendanzagaeski left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[build] Use API-21 for all native builds #4584

[build] Use API-21 for all native builds #4584

Uh oh!

Conversation

grendello commented Apr 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brendanzagaeski commented Apr 21, 2020

Uh oh!

grendello commented Apr 21, 2020

Uh oh!

brendanzagaeski left a comment

Choose a reason for hiding this comment

Uh oh!

jonpryor Apr 24, 2020

Choose a reason for hiding this comment

Uh oh!

grendello commented Apr 27, 2020

Uh oh!

azure-pipelines bot commented Apr 27, 2020

Uh oh!

brendanzagaeski left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

grendello commented Apr 20, 2020 •

edited

Loading