[tests] New apk size regression testing #4545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use apkdiff and description files to check for apk size regression. The new `ApkDiffCheckRegression` tool task handles running `apkdiff` tool and creates `TestResult` file for convenient CI reporting.
Member
Author
|
Note that this is draft PR with wrong |
Looks like we don't run instrumentation tests in Debug configuration
Member
Author
|
Looks like we don't run instrumentation tests with Debug configuration. Maybe we should start running them again? |
to location where CI is expecting the test results files.
This was referenced Apr 17, 2020
jonpryor
pushed a commit
that referenced
this pull request
Apr 17, 2020
Use `apkdiff` (2e28f2e) and `.apkdesc` description files to check for `.apk` size regressions. This allows for more informative and useful messages when `.apk` size regressions occur, e.g. Saving apk description to '../../../bin/TestRelease/Xamarin.Forms_Performance_Integration-Signed.apkdesc' Size difference in bytes ([*1] apk1 only, [*2] apk2 only): 100,000 assemblies/Mono.Android.dll Error: apkdiff: Assembly 'assemblies/Mono.Android.dll' size increase 100,000 is 48,800 bytes more than the threshold 51,200. 492 lib/armeabi-v7a/libmonodroid.so 216 lib/x86/libmonodroid.so Summary: 100,000 Assemblies 0.71% (of 14,080,480) 708 Shared libraries 0.01% (of 11,855,444) 0 Package size difference 0.00% (of 21,007,581) Error: apkdiff: Size regression occured, 1 check(s) failed. The new `<ApkDiffCheckRegression/>` task handles running the `apkdiff` tool and creates `TestResult*.xml` files for convenient CI reporting of `.apk` size regressions. Add `tests/apk-sizes-reference/*.apkdesc` files to contain "expected sizes" for verification.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use apkdiff and description files to check for apk size regression.
The new
ApkDiffCheckRegressiontool task handles runningapkdifftool and creates
TestResultfile for convenient CI reporting.