Skip to content

Bump to xamarin/Java.Interop/master@d70e40f1 #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

Bump to xamarin/Java.Interop/master@d70e40f1 #4467

merged 1 commit into from
Mar 31, 2020

Conversation

@jonpryor
Copy link
Contributor

@jonpryor jonpryor commented Mar 26, 2020 •
edited
Loading

@jonpryor
Copy link
Contributor Author

jonpryor commented Mar 27, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 27, 2020

Pull request contains merge conflicts.

jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Mar 27, 2020
@jonpryor
[xabuild] Probe DOTNET_ROOT for .NET sdks
1f44dac 
Context: dotnet#4467
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=3590265&view=logs&j=96fd57f5-f69e-53c7-3d47-f67e6cf9b93e&t=7b19ceb3-907a-5a0d-b8ed-87e3f7335a58

When trying to integration test dotnet/java-interop#614, the
`make all-tests` job fails:

	/usr/local/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(137,5):
	error NETSDK1045: The current .NET SDK does not support targeting .NET Core 3.1.  Either target .NET Core 2.2 or lower, or use a version of the .NET SDK that supports .NET Core 3.1.
	[/Users/builder/azdo/_work/2/s/xamarin-android/external/Java.Interop/src/Java.Interop/Java.Interop.csproj]

Particularly odd about this is that we have an explicit job to install
.NET Core 3.1.100, so why is .NET Core 2.2.402 being used at all?!

Turns Out™ that while .NET Core 3.1.100 was installed, it was
installed *into a different prefix*; from the
`install .NET Core 3.1.100` job:

	##[debug]set DOTNET_ROOT=/Users/builder/azdo/_work/_tool/dotnet

and from the `make jenkins` job output:

	DOTNET_ROOT = /Users/builder/azdo/_work/_tool/dotnet

Thus, the `install .NET Core 3.1.100` job is installing .NET Core into
`$HOME/azdo/_work/_tool/_dotnet`, while `make all-tests` is only
looking for .NET Core SDKs within `/usr/local/share/dotnet`, which
does *not* contain .NET Core 3.1 at all.

Where does the `make all-tests` path come from?  It comes from
`tools/xabuild`, which sets the `MSBuildSDKsPath` environment
variable, and `xabuild` did not check `$DOTNET_ROOT`.

Update `xabuild` so that `$DOTNET_ROOT` is also probed for .NET Core
installation directories, and use the *latest* .NET Core SDK path
found between `$DOTNET_ROOT` and `/usr/local/share/dotnet`.
jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Mar 27, 2020
@jonpryor
[xabuild] Probe DOTNET_ROOT for .NET sdks
e1a4a41 
Context: dotnet#4467
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=3590265&view=logs&j=96fd57f5-f69e-53c7-3d47-f67e6cf9b93e&t=7b19ceb3-907a-5a0d-b8ed-87e3f7335a58

When trying to integration test dotnet/java-interop#614, the
`make all-tests` job fails:

	/usr/local/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(137,5):
	error NETSDK1045: The current .NET SDK does not support targeting .NET Core 3.1.  Either target .NET Core 2.2 or lower, or use a version of the .NET SDK that supports .NET Core 3.1.
	[/Users/builder/azdo/_work/2/s/xamarin-android/external/Java.Interop/src/Java.Interop/Java.Interop.csproj]

Particularly odd about this is that we have an explicit job to install
.NET Core 3.1.100, so why is .NET Core 2.2.402 being used at all?!

Turns Out™ that while .NET Core 3.1.100 was installed, it was
installed *into a different prefix*; from the
`install .NET Core 3.1.100` job:

	##[debug]set DOTNET_ROOT=/Users/builder/azdo/_work/_tool/dotnet

and from the `make jenkins` job output:

	DOTNET_ROOT = /Users/builder/azdo/_work/_tool/dotnet

Thus, the `install .NET Core 3.1.100` job is installing .NET Core into
`$HOME/azdo/_work/_tool/dotnet`, while `make all-tests` is only
looking for .NET Core SDKs within `/usr/local/share/dotnet`, which
does *not* contain .NET Core 3.1 at all.

Where does the `make all-tests` path come from?  It comes from
`tools/xabuild`, which sets the `MSBuildSDKsPath` environment
variable, and `xabuild` did not check `$DOTNET_ROOT`.

Update `xabuild` so that `$DOTNET_ROOT` is also probed for .NET Core
installation directories, and use the *latest* .NET Core SDK path
found between `$DOTNET_ROOT` and `/usr/local/share/dotnet`.
jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Mar 27, 2020
@jonpryor
[xabuild] Probe DOTNET_ROOT for .NET sdks
da7b44c 
Context: dotnet#4467
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=3590265&view=logs&j=96fd57f5-f69e-53c7-3d47-f67e6cf9b93e&t=7b19ceb3-907a-5a0d-b8ed-87e3f7335a58

When trying to integration test dotnet/java-interop#614, the
`make all-tests` job fails:

	/usr/local/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(137,5):
	error NETSDK1045: The current .NET SDK does not support targeting .NET Core 3.1.  Either target .NET Core 2.2 or lower, or use a version of the .NET SDK that supports .NET Core 3.1.
	[/Users/builder/azdo/_work/2/s/xamarin-android/external/Java.Interop/src/Java.Interop/Java.Interop.csproj]

Particularly odd about this is that we have an explicit job to install
.NET Core 3.1.100, so why is .NET Core 2.2.402 being used at all?!

Turns Out™ that while .NET Core 3.1.100 was installed, it was
installed *into a different prefix*; from the
`install .NET Core 3.1.100` job:

	##[debug]set DOTNET_ROOT=/Users/builder/azdo/_work/_tool/dotnet

and from the `make jenkins` job output:

	DOTNET_ROOT = /Users/builder/azdo/_work/_tool/dotnet

Thus, the `install .NET Core 3.1.100` job is installing .NET Core into
`$HOME/azdo/_work/_tool/dotnet`, while `make all-tests` is only
looking for .NET Core SDKs within `/usr/local/share/dotnet`, which
does *not* contain .NET Core 3.1 at all.

Where does the `make all-tests` path come from?  It comes from
`tools/xabuild`, which sets the `MSBuildSDKsPath` environment
variable, and `xabuild` did not check `$DOTNET_ROOT`.

Update `xabuild` so that `$DOTNET_ROOT` is also probed for .NET Core
installation directories, and use the *latest* .NET Core SDK path
found between `$DOTNET_ROOT` and `/usr/local/share/dotnet`.
@jonpryor jonpryor mentioned this pull request Mar 27, 2020
Merged
jonpryor added a commit that referenced this pull request Mar 28, 2020
@jonpryor
[xabuild] Probe DOTNET_ROOT for .NET sdks (#4474)
98d6bb5 
Context: #4467
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=3590265&view=logs&j=96fd57f5-f69e-53c7-3d47-f67e6cf9b93e&t=7b19ceb3-907a-5a0d-b8ed-87e3f7335a58

When trying to integration test dotnet/java-interop#614, the
`make all-tests` job fails:

	/usr/local/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(137,5):
	error NETSDK1045: The current .NET SDK does not support targeting .NET Core 3.1.  Either target .NET Core 2.2 or lower, or use a version of the .NET SDK that supports .NET Core 3.1.
	[/Users/builder/azdo/_work/2/s/xamarin-android/external/Java.Interop/src/Java.Interop/Java.Interop.csproj]

Particularly odd about this is that we have an explicit job to install
.NET Core 3.1.100, so why is .NET Core 2.2.402 being used at all?!

Turns Out™ that while .NET Core 3.1.100 was installed, it was
installed *into a different prefix*; from the
`install .NET Core 3.1.100` job:

	##[debug]set DOTNET_ROOT=/Users/builder/azdo/_work/_tool/dotnet

and from the `make jenkins` job output:

	DOTNET_ROOT = /Users/builder/azdo/_work/_tool/dotnet

Thus, the `install .NET Core 3.1.100` job is installing .NET Core into
`$HOME/azdo/_work/_tool/dotnet`, while `make all-tests` is only
looking for .NET Core SDKs within `/usr/local/share/dotnet`, which
does *not* contain .NET Core 3.1 at all.

Where does the `make all-tests` path come from?  It comes from
`tools/xabuild`, which sets the `MSBuildSDKsPath` environment
variable, and `xabuild` did not check `$DOTNET_ROOT`.

Update `xabuild` so that `$DOTNET_ROOT` is also probed for .NET Core
installation directories, and use the *latest* .NET Core SDK path
found between `$DOTNET_ROOT` and `/usr/local/share/dotnet`.
jonpryor added a commit that referenced this pull request Mar 30, 2020
@jonpryor
[xabuild] Probe DOTNET_ROOT for .NET sdks (#4474)
611c59a 
Context: #4467
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=3590265&view=logs&j=96fd57f5-f69e-53c7-3d47-f67e6cf9b93e&t=7b19ceb3-907a-5a0d-b8ed-87e3f7335a58

When trying to integration test dotnet/java-interop#614, the
`make all-tests` job fails:

	/usr/local/share/dotnet/sdk/2.2.402/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(137,5):
	error NETSDK1045: The current .NET SDK does not support targeting .NET Core 3.1.  Either target .NET Core 2.2 or lower, or use a version of the .NET SDK that supports .NET Core 3.1.
	[/Users/builder/azdo/_work/2/s/xamarin-android/external/Java.Interop/src/Java.Interop/Java.Interop.csproj]

Particularly odd about this is that we have an explicit job to install
.NET Core 3.1.100, so why is .NET Core 2.2.402 being used at all?!

Turns Out™ that while .NET Core 3.1.100 was installed, it was
installed *into a different prefix*; from the
`install .NET Core 3.1.100` job:

	##[debug]set DOTNET_ROOT=/Users/builder/azdo/_work/_tool/dotnet

and from the `make jenkins` job output:

	DOTNET_ROOT = /Users/builder/azdo/_work/_tool/dotnet

Thus, the `install .NET Core 3.1.100` job is installing .NET Core into
`$HOME/azdo/_work/_tool/dotnet`, while `make all-tests` is only
looking for .NET Core SDKs within `/usr/local/share/dotnet`, which
does *not* contain .NET Core 3.1 at all.

Where does the `make all-tests` path come from?  It comes from
`tools/xabuild`, which sets the `MSBuildSDKsPath` environment
variable, and `xabuild` did not check `$DOTNET_ROOT`.

Update `xabuild` so that `$DOTNET_ROOT` is also probed for .NET Core
installation directories, and use the *latest* .NET Core SDK path
found between `$DOTNET_ROOT` and `/usr/local/share/dotnet`.
@jonpryor jonpryor changed the title Bump to jonpryor/Java.Interop/jonp-ji-netcoreapp-build@1a309751 Bump to xamarin/Java.Interop/master@d70e40f1 Mar 30, 2020
@jonpryor jonpryor marked this pull request as ready for review March 30, 2020 23:41
@jonpryor jonpryor merged commit ca015b1 into dotnet:master Mar 31, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Published: 11.0 (d16-7)

Development

Successfully merging this pull request may close these issues.

2 participants

@jonpryor @brendanzagaeski