[Mono.Android.Export] Build against netcoreapp3.1 #4456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We expect the .NET 5 BCL to closely resemble the .NET Core 3.1 BCL. Continue preparing for .NET 5 and build `Mono.Android.Export.dll` against the `netcoreapp3.1` target framework, to ensure that the APIs that we need actually exist.
pjcollins
commented
Mar 24, 2020
jonpryor
reviewed
Mar 24, 2020
jonpryor
reviewed
Mar 24, 2020
Member
Author
|
Now that (most if not all) of the regression test issues have been sorted, I'm going to manually run a full test build against this: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=3583404&view=results |
Member
Author
|
Clearly there are still some regression test issues to sort out, but none of the regular PR checks seem to be reporting any issues out of the current set of failures happening elsewhere. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect the .NET 5 BCL to closely resemble the .NET Core 3.1 BCL.
Continue preparing for .NET 5 and build
Mono.Android.Export.dllagainst the
netcoreapp3.1target framework, to ensure that the APIsthat we need actually exist.